From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
Date: Tue, 01 Mar 2011 20:47:00 -0000 [thread overview]
Message-ID: <4D6D5B44.9020500@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 71 bytes --]
If frame is null, we will have crashed already from dereferencing it.
[-- Attachment #2: reversenull3.txt --]
[-- Type: text/plain, Size: 865 bytes --]
2011-03-01 Michael Snyder <msnyder@vmware.com>
* std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
Index: std-regs.c
===================================================================
RCS file: /cvs/src/src/gdb/std-regs.c,v
retrieving revision 1.31
diff -u -p -u -p -r1.31 std-regs.c
--- std-regs.c 1 Jan 2011 15:33:16 -0000 1.31
+++ std-regs.c 1 Mar 2011 20:42:48 -0000
@@ -70,11 +70,8 @@ value_of_builtin_frame_pc_reg (struct fr
struct value *val = allocate_value (func_ptr_type);
gdb_byte *buf = value_contents_raw (val);
- if (frame == NULL)
- memset (buf, 0, TYPE_LENGTH (value_type (val)));
- else
- gdbarch_address_to_pointer (gdbarch, func_ptr_type,
- buf, get_frame_pc (frame));
+ gdbarch_address_to_pointer (gdbarch, func_ptr_type,
+ buf, get_frame_pc (frame));
return val;
}
}
next reply other threads:[~2011-03-01 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 20:47 Michael Snyder [this message]
2011-03-01 21:40 ` Pedro Alves
2011-03-01 21:47 ` Michael Snyder
2011-03-01 21:52 ` Pedro Alves
2011-03-01 21:56 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D5B44.9020500@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox