From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9893 invoked by alias); 1 Mar 2011 21:56:58 -0000 Received: (qmail 9885 invoked by uid 22791); 1 Mar 2011 21:56:57 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 21:56:51 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id AD59149009; Tue, 1 Mar 2011 13:56:50 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id A3509CD9EE; Tue, 1 Mar 2011 13:56:50 -0800 (PST) Message-ID: <4D6D6BA2.6060301@vmware.com> Date: Tue, 01 Mar 2011 21:56:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame. References: <4D6D5B44.9020500@vmware.com> <201103012139.59726.pedro@codesourcery.com> <201103012152.01746.pedro@codesourcery.com> In-Reply-To: <201103012152.01746.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00059.txt.bz2 Pedro Alves wrote: > On Tuesday 01 March 2011 21:39:59, Pedro Alves wrote: >> On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote: >>> If frame is null, we will have crashed already from dereferencing it. >> Yeah, looks like a left over from before the "there's always >> a frame" changes years ago. >> >>> reversenull3.txt >>> 2011-03-01 Michael Snyder >>> >>> * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null. >> Okay. > > Similar dead code in value_of_builtin_frame_fp_reg btw. > Got it. Checked in.