From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13184 invoked by alias); 1 Mar 2011 21:40:07 -0000 Received: (qmail 13119 invoked by uid 22791); 1 Mar 2011 21:40:06 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 21:40:02 +0000 Received: (qmail 21345 invoked from network); 1 Mar 2011 21:40:00 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Mar 2011 21:40:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame. Date: Tue, 01 Mar 2011 21:40:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D6D5B44.9020500@vmware.com> In-Reply-To: <4D6D5B44.9020500@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103012139.59726.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00051.txt.bz2 On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote: > If frame is null, we will have crashed already from dereferencing it. Yeah, looks like a left over from before the "there's always a frame" changes years ago. > reversenull3.txt > 2011-03-01 Michael Snyder > > * std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null. Okay. -- Pedro Alves