* [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
@ 2010-04-01 9:15 Hui Zhu
2010-04-01 21:51 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Hui Zhu @ 2010-04-01 9:15 UTC (permalink / raw)
To: gdb-patches ml
Hi,
I remove 2 lines in this function because *addr already set to 0 in
the begin of this function.
Please help me review it.
Thanks,
Hui
2010-04-01 Hui Zhu <teawater@gmail.com>
* i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
"*addr = 0".
---
i386-tdep.c | 8 --------
1 file changed, 8 deletions(-)
--- a/i386-tdep.c
+++ b/i386-tdep.c
@@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
*addr += irp->addr + irp->rip_offset;
}
- else
- {
- *addr = 0;
- }
break;
case 1:
if (target_read_memory (irp->addr, buf, 1))
@@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
irp->rm = 0;
goto no_rm;
}
- else
- {
- *addr = 0;
- }
break;
case 1:
if (target_read_memory (irp->addr, buf, 1))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
2010-04-01 9:15 [RFA] Prec: remove useless line in i386_record_lea_modrm_addr Hui Zhu
@ 2010-04-01 21:51 ` Michael Snyder
2010-04-02 5:20 ` Hui Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2010-04-01 21:51 UTC (permalink / raw)
To: Hui Zhu; +Cc: gdb-patches ml
OK.
Hui Zhu wrote:
> Hi,
>
> I remove 2 lines in this function because *addr already set to 0 in
> the begin of this function.
>
> Please help me review it.
>
> Thanks,
> Hui
>
> 2010-04-01 Hui Zhu <teawater@gmail.com>
>
> * i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
> "*addr = 0".
>
>
> ---
> i386-tdep.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> --- a/i386-tdep.c
> +++ b/i386-tdep.c
> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
> if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
> *addr += irp->addr + irp->rip_offset;
> }
> - else
> - {
> - *addr = 0;
> - }
> break;
> case 1:
> if (target_read_memory (irp->addr, buf, 1))
> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
> irp->rm = 0;
> goto no_rm;
> }
> - else
> - {
> - *addr = 0;
> - }
> break;
> case 1:
> if (target_read_memory (irp->addr, buf, 1))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
2010-04-01 21:51 ` Michael Snyder
@ 2010-04-02 5:20 ` Hui Zhu
0 siblings, 0 replies; 3+ messages in thread
From: Hui Zhu @ 2010-04-02 5:20 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches ml
Checked in.
Thanks,
Hui
On Fri, Apr 2, 2010 at 05:51, Michael Snyder <msnyder@vmware.com> wrote:
> OK.
>
> Hui Zhu wrote:
>>
>> Hi,
>>
>> I remove 2 lines in this function because *addr already set to 0 in
>> the begin of this function.
>>
>> Please help me review it.
>>
>> Thanks,
>> Hui
>>
>> 2010-04-01 Hui Zhu <teawater@gmail.com>
>>
>> * i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
>> "*addr = 0".
>>
>>
>> ---
>> i386-tdep.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> --- a/i386-tdep.c
>> +++ b/i386-tdep.c
>> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
>> if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
>> *addr += irp->addr + irp->rip_offset;
>> }
>> - else
>> - {
>> - *addr = 0;
>> - }
>> break;
>> case 1:
>> if (target_read_memory (irp->addr, buf, 1))
>> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
>> irp->rm = 0;
>> goto no_rm;
>> }
>> - else
>> - {
>> - *addr = 0;
>> - }
>> break;
>> case 1:
>> if (target_read_memory (irp->addr, buf, 1))
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-02 5:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-01 9:15 [RFA] Prec: remove useless line in i386_record_lea_modrm_addr Hui Zhu
2010-04-01 21:51 ` Michael Snyder
2010-04-02 5:20 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox