From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71709-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12508 invoked by alias); 1 Apr 2010 21:51:28 -0000
Received: (qmail 12454 invoked by uid 22791); 1 Apr 2010 21:51:21 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 21:51:16 +0000
Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 100EF1A048; 	Thu,  1 Apr 2010 14:51:15 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) 	by jupiter.vmware.com (Postfix) with ESMTP id 03F9FDC07E; 	Thu,  1 Apr 2010 14:51:15 -0700 (PDT)
Message-ID: <4BB51552.4030909@vmware.com>
Date: Thu, 01 Apr 2010 21:51:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100311)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
References: <s2odaef60381004010215q309631co5987ac5c1e4b33bc@mail.gmail.com>
In-Reply-To: <s2odaef60381004010215q309631co5987ac5c1e4b33bc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00028.txt.bz2

OK.

Hui Zhu wrote:
> Hi,
> 
> I remove 2 lines in this function because *addr already set to 0 in
> the begin of this function.
> 
> Please help me review it.
> 
> Thanks,
> Hui
> 
> 2010-04-01  Hui Zhu  <teawater@gmail.com>
> 
> 	* i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
> 	"*addr = 0".
> 
> 
> ---
>  i386-tdep.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> --- a/i386-tdep.c
> +++ b/i386-tdep.c
> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
>  	      if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
>  		*addr += irp->addr + irp->rip_offset;
>  	    }
> -	  else
> -	    {
> -	      *addr = 0;
> -	    }
>  	  break;
>  	case 1:
>  	  if (target_read_memory (irp->addr, buf, 1))
> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
>  	      irp->rm = 0;
>  	      goto no_rm;
>  	    }
> -	  else
> -	    {
> -	      *addr = 0;
> -	    }
>  	  break;
>  	case 1:
>  	  if (target_read_memory (irp->addr, buf, 1))