From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11581 invoked by alias); 1 Apr 2010 09:15:53 -0000 Received: (qmail 11557 invoked by uid 22791); 1 Apr 2010 09:15:52 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 09:15:46 +0000 Received: by pwi2 with SMTP id 2so1096720pwi.0 for ; Thu, 01 Apr 2010 02:15:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.101.12 with HTTP; Thu, 1 Apr 2010 02:15:25 -0700 (PDT) From: Hui Zhu Date: Thu, 01 Apr 2010 09:15:00 -0000 Received: by 10.142.250.21 with SMTP id x21mr93591wfh.263.1270113345107; Thu, 01 Apr 2010 02:15:45 -0700 (PDT) Message-ID: Subject: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr To: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00002.txt.bz2 Hi, I remove 2 lines in this function because *addr already set to 0 in the begin of this function. Please help me review it. Thanks, Hui 2010-04-01 Hui Zhu * i386-tdep.c (i386_record_lea_modrm_addr): Remove useless "*addr = 0". --- i386-tdep.c | 8 -------- 1 file changed, 8 deletions(-) --- a/i386-tdep.c +++ b/i386-tdep.c @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_ if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib) *addr += irp->addr + irp->rip_offset; } - else - { - *addr = 0; - } break; case 1: if (target_read_memory (irp->addr, buf, 1)) @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_ irp->rm = 0; goto no_rm; } - else - { - *addr = 0; - } break; case 1: if (target_read_memory (irp->addr, buf, 1))