From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71722-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10420 invoked by alias); 2 Apr 2010 05:20:26 -0000
Received: (qmail 10390 invoked by uid 22791); 2 Apr 2010 05:20:24 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f202.google.com (HELO mail-pz0-f202.google.com) (209.85.222.202)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Apr 2010 05:20:17 +0000
Received: by pzk40 with SMTP id 40so1343448pzk.23         for <gdb-patches@sourceware.org>; Thu, 01 Apr 2010 22:20:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.101.12 with HTTP; Thu, 1 Apr 2010 22:19:56 -0700 (PDT)
In-Reply-To: <4BB51552.4030909@vmware.com>
References: <s2odaef60381004010215q309631co5987ac5c1e4b33bc@mail.gmail.com>  	<4BB51552.4030909@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Fri, 02 Apr 2010 05:20:00 -0000
Received: by 10.142.195.3 with SMTP id s3mr641722wff.329.1270185616143; Thu,  	01 Apr 2010 22:20:16 -0700 (PDT)
Message-ID: <g2idaef60381004012219yfeacd07avcf9cf5121f9d8605@mail.gmail.com>
Subject: Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
To: Michael Snyder <msnyder@vmware.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00041.txt.bz2

Checked in.

Thanks,
Hui

On Fri, Apr 2, 2010 at 05:51, Michael Snyder <msnyder@vmware.com> wrote:
> OK.
>
> Hui Zhu wrote:
>>
>> Hi,
>>
>> I remove 2 lines in this function because *addr already set to 0 in
>> the begin of this function.
>>
>> Please help me review it.
>>
>> Thanks,
>> Hui
>>
>> 2010-04-01 =A0Hui Zhu =A0<teawater@gmail.com>
>>
>> =A0 =A0 =A0 =A0* i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
>> =A0 =A0 =A0 =A0"*addr =3D 0".
>>
>>
>> ---
>> =A0i386-tdep.c | =A0 =A08 --------
>> =A01 file changed, 8 deletions(-)
>>
>> --- a/i386-tdep.c
>> +++ b/i386-tdep.c
>> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0if (irp->regmap[X86_RECORD_R8_REGNUM] && !hav=
esib)
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*addr +=3D irp->addr + irp->rip_offset;
>> =A0 =A0 =A0 =A0 =A0 =A0}
>> - =A0 =A0 =A0 =A0 else
>> - =A0 =A0 =A0 =A0 =A0 {
>> - =A0 =A0 =A0 =A0 =A0 =A0 *addr =3D 0;
>> - =A0 =A0 =A0 =A0 =A0 }
>> =A0 =A0 =A0 =A0 =A0break;
>> =A0 =A0 =A0 =A0case 1:
>> =A0 =A0 =A0 =A0 =A0if (target_read_memory (irp->addr, buf, 1))
>> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0irp->rm =3D 0;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0goto no_rm;
>> =A0 =A0 =A0 =A0 =A0 =A0}
>> - =A0 =A0 =A0 =A0 else
>> - =A0 =A0 =A0 =A0 =A0 {
>> - =A0 =A0 =A0 =A0 =A0 =A0 *addr =3D 0;
>> - =A0 =A0 =A0 =A0 =A0 }
>> =A0 =A0 =A0 =A0 =A0break;
>> =A0 =A0 =A0 =A0case 1:
>> =A0 =A0 =A0 =A0 =A0if (target_read_memory (irp->addr, buf, 1))
>
>