From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr
Date: Thu, 01 Apr 2010 21:51:00 -0000 [thread overview]
Message-ID: <4BB51552.4030909@vmware.com> (raw)
In-Reply-To: <s2odaef60381004010215q309631co5987ac5c1e4b33bc@mail.gmail.com>
OK.
Hui Zhu wrote:
> Hi,
>
> I remove 2 lines in this function because *addr already set to 0 in
> the begin of this function.
>
> Please help me review it.
>
> Thanks,
> Hui
>
> 2010-04-01 Hui Zhu <teawater@gmail.com>
>
> * i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
> "*addr = 0".
>
>
> ---
> i386-tdep.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> --- a/i386-tdep.c
> +++ b/i386-tdep.c
> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
> if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
> *addr += irp->addr + irp->rip_offset;
> }
> - else
> - {
> - *addr = 0;
> - }
> break;
> case 1:
> if (target_read_memory (irp->addr, buf, 1))
> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
> irp->rm = 0;
> goto no_rm;
> }
> - else
> - {
> - *addr = 0;
> - }
> break;
> case 1:
> if (target_read_memory (irp->addr, buf, 1))
next prev parent reply other threads:[~2010-04-01 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 9:15 Hui Zhu
2010-04-01 21:51 ` Michael Snyder [this message]
2010-04-02 5:20 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB51552.4030909@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox