[Patch] Exit gdb/configure.tgt for unsupported targets

[Patch] Exit gdb/configure.tgt for unsupported targets

[Ralf Corsepius]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

Hi,

The patch below (against 7.0.90) is meant to address the issues I 
reported in
http://sourceware.org/ml/gdb/2010-02/msg00140.html

Ralf


[-- Attachment #2: gdb-7.0.90-gdb-configure.tgt.diff --]
[-- Type: text/plain, Size: 530 bytes --]

2010-02-23	Ralf Corsépius <ralf.corsepius@rtems.org>

	* configure.tgt: Exit if ${gdb_target_obs}" is not set.

diff -Naur gdb-7.0.90.orig/gdb/configure.tgt gdb-7.0.90/gdb/configure.tgt
--- gdb-7.0.90.orig/gdb/configure.tgt	2010-01-19 11:22:42.000000000 +0100
+++ gdb-7.0.90/gdb/configure.tgt	2010-02-23 05:43:01.000000000 +0100
@@ -611,6 +611,11 @@
 
 esac
 
+if test -z "${gdb_target_obs}"; then
+    echo "*** Configuration ${targ} is unsupported." >&2
+    exit 1
+fi
+
 # map target onto default OS ABI
 
 case "${targ}" in

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Tom Tromey]

>>>>> "Ralf" == Ralf Corsepius <ralf.corsepius@rtems.org> writes:

Ralf> 2010-02-23	Ralf Corsépius <ralf.corsepius@rtems.org>
Ralf> 	* configure.tgt: Exit if ${gdb_target_obs}" is not set.

Ralf> +if test -z "${gdb_target_obs}"; then
Ralf> +    echo "*** Configuration ${targ} is unsupported." >&2
Ralf> +    exit 1
Ralf> +fi

I think it would be better to do the test in configure.ac and use
AC_MSG_ERROR.

Tom

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Ralf Corsepius]

On 02/24/2010 05:51 PM, Tom Tromey wrote:
>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org>  writes:
>>>>>>              
> Ralf>  2010-02-23	Ralf Corsépius<ralf.corsepius@rtems.org>
> Ralf>  	* configure.tgt: Exit if ${gdb_target_obs}" is not set.
>
> Ralf>  +if test -z "${gdb_target_obs}"; then
> Ralf>  +    echo "*** Configuration ${targ} is unsupported.">&2
> Ralf>  +    exit 1
> Ralf>  +fi
>
> I think it would be better to do the test in configure.ac and use
> AC_MSG_ERROR.
>    
I wasn't aware "${gdb_target_obs}" is exported to configure.ac and 
intended to keep configure.tgt self-contained ;)

Now that it apparently is exported and used in configure.ac, I agree 
with you, configure.ac+AC_MSG_ERROR would be better.

Ralf

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Ralf Corsepius]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On 02/24/2010 06:00 PM, Ralf Corsepius wrote:
> On 02/24/2010 05:51 PM, Tom Tromey wrote:
>>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org> writes:
>> Ralf> 2010-02-23 Ralf Corsépius<ralf.corsepius@rtems.org>
>> Ralf> * configure.tgt: Exit if ${gdb_target_obs}" is not set.
>>
>> Ralf> +if test -z "${gdb_target_obs}"; then
>> Ralf> + echo "*** Configuration ${targ} is unsupported.">&2
>> Ralf> + exit 1
>> Ralf> +fi
>>
>> I think it would be better to do the test in configure.ac and use
>> AC_MSG_ERROR.
> I wasn't aware "${gdb_target_obs}" is exported to configure.ac and
> intended to keep configure.tgt self-contained ;)
>
> Now that it apparently is exported and used in configure.ac, I agree
> with you, configure.ac+AC_MSG_ERROR would be better.

Reworked patch enclosed below.

Ralf



[-- Attachment #2: gdb-7.0.90-gdb-configure.diff --]
[-- Type: text/plain, Size: 1176 bytes --]

2010-02-25	Ralf Corsépius <ralf.corsepius@rtems.org>

	* configure.ac: Exit if ${gdb_target_obs}" is not set.
	* configure: Regenerate.

diff -Naur gdb-7.0.90.orig/gdb/configure gdb-7.0.90-rtems4.10-20100225/gdb/configure
--- gdb-7.0.90.orig/gdb/configure	2010-02-19 01:23:00.000000000 +0100
+++ gdb-7.0.90-rtems4.10-20100225/gdb/configure	2010-02-25 05:25:54.000000000 +0100
@@ -6927,6 +6927,10 @@
 
     . ${srcdir}/configure.tgt
 
+    if test -z "${gdb_target_obs}"; then :
+  as_fn_error "configuration ${targ} is unsupported." "$LINENO" 5
+fi
+
     # Target-specific object files
     for i in ${gdb_target_obs}; do
         case " $TARGET_OBS " in
diff -Naur gdb-7.0.90.orig/gdb/configure.ac gdb-7.0.90-rtems4.10-20100225/gdb/configure.ac
--- gdb-7.0.90.orig/gdb/configure.ac	2010-02-19 01:23:00.000000000 +0100
+++ gdb-7.0.90-rtems4.10-20100225/gdb/configure.ac	2010-02-25 05:25:48.000000000 +0100
@@ -161,6 +161,9 @@
 
     . ${srcdir}/configure.tgt
 
+    AS_IF([test -z "${gdb_target_obs}"],
+      [AC_MSG_ERROR([configuration ${targ} is unsupported.])])
+
     # Target-specific object files
     for i in ${gdb_target_obs}; do
         case " $TARGET_OBS " in

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Tom Tromey]

>>>>> "Ralf" == Ralf Corsepius <ralf.corsepius@rtems.org> writes:

Ralf> 2010-02-25	Ralf Corsépius <ralf.corsepius@rtems.org>
Ralf> 	* configure.ac: Exit if ${gdb_target_obs}" is not set.
Ralf> 	* configure: Regenerate.

This is ok, thanks.

Tom

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Ralf Corsepius]

On 02/25/2010 06:46 PM, Tom Tromey wrote:
>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org>  writes:
>
> Ralf>  2010-02-25	Ralf Corsépius<ralf.corsepius@rtems.org>
> Ralf>  	* configure.ac: Exit if ${gdb_target_obs}" is not set.
> Ralf>  	* configure: Regenerate.
>
> This is ok, thanks.

Could somebody please apply this patch (trunk and 7.1-branch).

I don't have write access to gdb.

Thanks,
	Ralf

Re: [Patch] Exit gdb/configure.tgt for unsupported targets

[Joel Brobecker]

> >Ralf>  2010-02-25	Ralf Corsépius<ralf.corsepius@rtems.org>
> >Ralf>  	* configure.ac: Exit if ${gdb_target_obs}" is not set.
> >Ralf>  	* configure: Regenerate.
> >
> >This is ok, thanks.
> 
> Could somebody please apply this patch (trunk and 7.1-branch).

Checked in. I hesitated about applying to the branch or not, since
this is hardly a critical problem, but since it seemed pretty safe
and might be helpful, I ended up agreeing with the suggestion. So,
it's been applied to the branch as well.

> I don't have write access to gdb.

Perhaps you might want to have write access?  Please send me an email
if you do (and let me know if you already have write access in any other
GNU project hosted on sourceware.org).

-- 
Joel