From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12194 invoked by alias); 24 Feb 2010 17:00:22 -0000
Received: (qmail 12169 invoked by uid 22791); 24 Feb 2010 17:00:20 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 	tests=AWL,BAYES_00,HK_OBFDOM
X-Spam-Check-By: sourceware.org
Received: from mout0.freenet.de (HELO mout0.freenet.de) (195.4.92.90)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Feb 2010 17:00:15 +0000
Received: from [195.4.92.11] (helo=1.mx.freenet.de) 	by mout0.freenet.de with esmtpa (ID ralf.corsepius@freenet.de) (port 25) (Exim 4.72 #1) 	id 1NkKaq-0006wC-DK; Wed, 24 Feb 2010 18:00:12 +0100
Received: from hsi-kbw-078-043-060-227.hsi4.kabel-badenwuerttemberg.de ([78.43.60.227]:59783 helo=[192.168.1.104]) 	by 1.mx.freenet.de with esmtpsa (ID ralf.corsepius@freenet.de) (TLSv1:AES256-SHA:256) (port 465) (Exim 4.72 #2) 	id 1NkKaq-0001XV-8W; Wed, 24 Feb 2010 18:00:12 +0100
Message-ID: <4B855B1A.7050006@rtems.org>
Date: Wed, 24 Feb 2010 17:00:00 -0000
From: Ralf Corsepius <ralf.corsepius@rtems.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1
MIME-Version: 1.0
To: tromey@redhat.com
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [Patch] Exit gdb/configure.tgt for unsupported targets
References: <4B8505E9.3050600@rtems.org> <m3ljeivaow.fsf@fleche.redhat.com>
In-Reply-To: <m3ljeivaow.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00600.txt.bz2

On 02/24/2010 05:51 PM, Tom Tromey wrote:
>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org>  writes:
>>>>>>              
> Ralf>  2010-02-23	Ralf Corsépius<ralf.corsepius@rtems.org>
> Ralf>  	* configure.tgt: Exit if ${gdb_target_obs}" is not set.
>
> Ralf>  +if test -z "${gdb_target_obs}"; then
> Ralf>  +    echo "*** Configuration ${targ} is unsupported.">&2
> Ralf>  +    exit 1
> Ralf>  +fi
>
> I think it would be better to do the test in configure.ac and use
> AC_MSG_ERROR.
>    
I wasn't aware "${gdb_target_obs}" is exported to configure.ac and 
intended to keep configure.tgt self-contained ;)

Now that it apparently is exported and used in configure.ac, I agree 
with you, configure.ac+AC_MSG_ERROR would be better.

Ralf