Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ralf Corsepius <ralf.corsepius@rtems.org>
To: tromey@redhat.com
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [Patch] Exit gdb/configure.tgt for unsupported targets
Date: Wed, 24 Feb 2010 17:00:00 -0000	[thread overview]
Message-ID: <4B855B1A.7050006@rtems.org> (raw)
In-Reply-To: <m3ljeivaow.fsf@fleche.redhat.com>

On 02/24/2010 05:51 PM, Tom Tromey wrote:
>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org>  writes:
>>>>>>              
> Ralf>  2010-02-23	Ralf Corsépius<ralf.corsepius@rtems.org>
> Ralf>  	* configure.tgt: Exit if ${gdb_target_obs}" is not set.
>
> Ralf>  +if test -z "${gdb_target_obs}"; then
> Ralf>  +    echo "*** Configuration ${targ} is unsupported.">&2
> Ralf>  +    exit 1
> Ralf>  +fi
>
> I think it would be better to do the test in configure.ac and use
> AC_MSG_ERROR.
>    
I wasn't aware "${gdb_target_obs}" is exported to configure.ac and 
intended to keep configure.tgt self-contained ;)

Now that it apparently is exported and used in configure.ac, I agree 
with you, configure.ac+AC_MSG_ERROR would be better.

Ralf


  reply	other threads:[~2010-02-24 17:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 10:56 Ralf Corsepius
2010-02-24 16:51 ` Tom Tromey
2010-02-24 17:00   ` Ralf Corsepius [this message]
2010-02-25  5:40     ` Ralf Corsepius
2010-02-25 17:46       ` Tom Tromey
2010-03-11 16:57         ` Ralf Corsepius
2010-03-15 17:10           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B855B1A.7050006@rtems.org \
    --to=ralf.corsepius@rtems.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox