From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8416 invoked by alias); 25 Feb 2010 05:40:51 -0000 Received: (qmail 8308 invoked by uid 22791); 25 Feb 2010 05:40:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from mout2.freenet.de (HELO mout2.freenet.de) (195.4.92.92) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Feb 2010 05:40:45 +0000 Received: from [195.4.92.20] (helo=10.mx.freenet.de) by mout2.freenet.de with esmtpa (ID ralf.corsepius@freenet.de) (port 25) (Exim 4.72 #1) id 1NkWSn-0003MK-C9; Thu, 25 Feb 2010 06:40:41 +0100 Received: from hsi-kbw-078-043-060-227.hsi4.kabel-badenwuerttemberg.de ([78.43.60.227]:62049 helo=[192.168.1.104]) by 10.mx.freenet.de with esmtpsa (ID ralf.corsepius@freenet.de) (TLSv1:AES256-SHA:256) (port 465) (Exim 4.72 #2) id 1NkWSn-0005iG-04; Thu, 25 Feb 2010 06:40:41 +0100 Message-ID: <4B860D57.3070408@rtems.org> Date: Thu, 25 Feb 2010 05:40:00 -0000 From: Ralf Corsepius User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: Ralf Corsepius , tromey@redhat.com Subject: Re: [Patch] Exit gdb/configure.tgt for unsupported targets References: <4B8505E9.3050600@rtems.org> <4B855B1A.7050006@rtems.org> In-Reply-To: <4B855B1A.7050006@rtems.org> Content-Type: multipart/mixed; boundary="------------020003080800040102000504" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00614.txt.bz2 This is a multi-part message in MIME format. --------------020003080800040102000504 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 805 On 02/24/2010 06:00 PM, Ralf Corsepius wrote: > On 02/24/2010 05:51 PM, Tom Tromey wrote: >>>>>>> "Ralf" == Ralf Corsepius writes: >> Ralf> 2010-02-23 Ralf Corsépius >> Ralf> * configure.tgt: Exit if ${gdb_target_obs}" is not set. >> >> Ralf> +if test -z "${gdb_target_obs}"; then >> Ralf> + echo "*** Configuration ${targ} is unsupported.">&2 >> Ralf> + exit 1 >> Ralf> +fi >> >> I think it would be better to do the test in configure.ac and use >> AC_MSG_ERROR. > I wasn't aware "${gdb_target_obs}" is exported to configure.ac and > intended to keep configure.tgt self-contained ;) > > Now that it apparently is exported and used in configure.ac, I agree > with you, configure.ac+AC_MSG_ERROR would be better. Reworked patch enclosed below. Ralf --------------020003080800040102000504 Content-Type: text/plain; name="gdb-7.0.90-gdb-configure.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gdb-7.0.90-gdb-configure.diff" Content-length: 1595 MjAxMC0wMi0yNQlSYWxmIENvcnPDqXBpdXMgPHJhbGYuY29yc2VwaXVzQHJ0 ZW1zLm9yZz4KCgkqIGNvbmZpZ3VyZS5hYzogRXhpdCBpZiAke2dkYl90YXJn ZXRfb2JzfSIgaXMgbm90IHNldC4KCSogY29uZmlndXJlOiBSZWdlbmVyYXRl LgoKZGlmZiAtTmF1ciBnZGItNy4wLjkwLm9yaWcvZ2RiL2NvbmZpZ3VyZSBn ZGItNy4wLjkwLXJ0ZW1zNC4xMC0yMDEwMDIyNS9nZGIvY29uZmlndXJlCi0t LSBnZGItNy4wLjkwLm9yaWcvZ2RiL2NvbmZpZ3VyZQkyMDEwLTAyLTE5IDAx OjIzOjAwLjAwMDAwMDAwMCArMDEwMAorKysgZ2RiLTcuMC45MC1ydGVtczQu MTAtMjAxMDAyMjUvZ2RiL2NvbmZpZ3VyZQkyMDEwLTAyLTI1IDA1OjI1OjU0 LjAwMDAwMDAwMCArMDEwMApAQCAtNjkyNyw2ICs2OTI3LDEwIEBACiAKICAg ICAuICR7c3JjZGlyfS9jb25maWd1cmUudGd0CiAKKyAgICBpZiB0ZXN0IC16 ICIke2dkYl90YXJnZXRfb2JzfSI7IHRoZW4gOgorICBhc19mbl9lcnJvciAi Y29uZmlndXJhdGlvbiAke3Rhcmd9IGlzIHVuc3VwcG9ydGVkLiIgIiRMSU5F Tk8iIDUKK2ZpCisKICAgICAjIFRhcmdldC1zcGVjaWZpYyBvYmplY3QgZmls ZXMKICAgICBmb3IgaSBpbiAke2dkYl90YXJnZXRfb2JzfTsgZG8KICAgICAg ICAgY2FzZSAiICRUQVJHRVRfT0JTICIgaW4KZGlmZiAtTmF1ciBnZGItNy4w LjkwLm9yaWcvZ2RiL2NvbmZpZ3VyZS5hYyBnZGItNy4wLjkwLXJ0ZW1zNC4x MC0yMDEwMDIyNS9nZGIvY29uZmlndXJlLmFjCi0tLSBnZGItNy4wLjkwLm9y aWcvZ2RiL2NvbmZpZ3VyZS5hYwkyMDEwLTAyLTE5IDAxOjIzOjAwLjAwMDAw MDAwMCArMDEwMAorKysgZ2RiLTcuMC45MC1ydGVtczQuMTAtMjAxMDAyMjUv Z2RiL2NvbmZpZ3VyZS5hYwkyMDEwLTAyLTI1IDA1OjI1OjQ4LjAwMDAwMDAw MCArMDEwMApAQCAtMTYxLDYgKzE2MSw5IEBACiAKICAgICAuICR7c3JjZGly fS9jb25maWd1cmUudGd0CiAKKyAgICBBU19JRihbdGVzdCAteiAiJHtnZGJf dGFyZ2V0X29ic30iXSwKKyAgICAgIFtBQ19NU0dfRVJST1IoW2NvbmZpZ3Vy YXRpb24gJHt0YXJnfSBpcyB1bnN1cHBvcnRlZC5dKV0pCisKICAgICAjIFRh cmdldC1zcGVjaWZpYyBvYmplY3QgZmlsZXMKICAgICBmb3IgaSBpbiAke2dk Yl90YXJnZXRfb2JzfTsgZG8KICAgICAgICAgY2FzZSAiICRUQVJHRVRfT0JT ICIgaW4K --------------020003080800040102000504--