* [RFA] Fix probable typo in i386_process_record
@ 2009-10-10 1:01 Michael Snyder
2009-10-10 5:51 ` Hui Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2009-10-10 1:01 UTC (permalink / raw)
To: gdb-patches, Hui Zhu
[-- Attachment #1: Type: text/plain, Size: 68 bytes --]
Hui, I'm *pretty* sure I got this right, but you'd better confirm:
[-- Attachment #2: typo.txt --]
[-- Type: text/plain, Size: 637 bytes --]
2009-10-09 Michael Snyder <msnyder@vmware.com>
* i386-tdep.c (i386_process_record): Or-equals, not not-equals.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.288
diff -u -p -r1.288 i386-tdep.c
--- i386-tdep.c 28 Sep 2009 07:11:36 -0000 1.288
+++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
@@ -4146,7 +4146,7 @@ reswitch:
return -1;
if (ir.mod == 3)
{
- ir.rm != ir.rex_b;
+ ir.rm |= ir.rex_b;
if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
ir.rm &= 0x3;
I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix probable typo in i386_process_record
2009-10-10 1:01 [RFA] Fix probable typo in i386_process_record Michael Snyder
@ 2009-10-10 5:51 ` Hui Zhu
2009-10-11 3:21 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Hui Zhu @ 2009-10-10 5:51 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
I think this patch is OK. Thanks a lot.
Hui
On Sat, Oct 10, 2009 at 08:57, Michael Snyder <msnyder@vmware.com> wrote:
> Hui, I'm *pretty* sure I got this right, but you'd better confirm:
>
>
> 2009-10-09 Michael Snyder <msnyder@vmware.com>
>
> * i386-tdep.c (i386_process_record): Or-equals, not not-equals.
>
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.288
> diff -u -p -r1.288 i386-tdep.c
> --- i386-tdep.c 28 Sep 2009 07:11:36 -0000 1.288
> +++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
> @@ -4146,7 +4146,7 @@ reswitch:
> return -1;
> if (ir.mod == 3)
> {
> - ir.rm != ir.rex_b;
> + ir.rm |= ir.rex_b;
> if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
> ir.rm &= 0x3;
> I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix probable typo in i386_process_record
2009-10-10 5:51 ` Hui Zhu
@ 2009-10-11 3:21 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2009-10-11 3:21 UTC (permalink / raw)
To: Hui Zhu; +Cc: gdb-patches
Committed.
Hui Zhu wrote:
> I think this patch is OK. Thanks a lot.
>
> Hui
>
> On Sat, Oct 10, 2009 at 08:57, Michael Snyder <msnyder@vmware.com> wrote:
>> Hui, I'm *pretty* sure I got this right, but you'd better confirm:
>>
>>
>> 2009-10-09 Michael Snyder <msnyder@vmware.com>
>>
>> * i386-tdep.c (i386_process_record): Or-equals, not not-equals.
>>
>> Index: i386-tdep.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
>> retrieving revision 1.288
>> diff -u -p -r1.288 i386-tdep.c
>> --- i386-tdep.c 28 Sep 2009 07:11:36 -0000 1.288
>> +++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
>> @@ -4146,7 +4146,7 @@ reswitch:
>> return -1;
>> if (ir.mod == 3)
>> {
>> - ir.rm != ir.rex_b;
>> + ir.rm |= ir.rex_b;
>> if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
>> ir.rm &= 0x3;
>> I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-11 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-10 1:01 [RFA] Fix probable typo in i386_process_record Michael Snyder
2009-10-10 5:51 ` Hui Zhu
2009-10-11 3:21 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox