From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67574-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16710 invoked by alias); 10 Oct 2009 01:01:27 -0000
Received: (qmail 16475 invoked by uid 22791); 10 Oct 2009 01:01:26 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Oct 2009 01:01:21 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 9529F55019; 	Fri,  9 Oct 2009 18:01:20 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id 85843C9BBE; 	Fri,  9 Oct 2009 18:01:20 -0700 (PDT)
Message-ID: <4ACFDBDC.1090500@vmware.com>
Date: Sat, 10 Oct 2009 01:01:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,   Hui Zhu <teawater@gmail.com>
Subject: [RFA] Fix probable typo in i386_process_record
Content-Type: multipart/mixed;  boundary="------------040602010307040708040204"
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00197.txt.bz2

This is a multi-part message in MIME format.
--------------040602010307040708040204
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-length: 68

Hui, I'm *pretty* sure I got this right, but you'd better confirm:


--------------040602010307040708040204
Content-Type: text/plain;
 name="typo.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="typo.txt"
Content-length: 637

2009-10-09  Michael Snyder  <msnyder@vmware.com>

	* i386-tdep.c (i386_process_record): Or-equals, not not-equals.

Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.288
diff -u -p -r1.288 i386-tdep.c
--- i386-tdep.c	28 Sep 2009 07:11:36 -0000	1.288
+++ i386-tdep.c	10 Oct 2009 00:58:09 -0000
@@ -4146,7 +4146,7 @@ reswitch:
 	return -1;
       if (ir.mod == 3)
 	{
-	  ir.rm != ir.rex_b;
+	  ir.rm |= ir.rex_b;
 	  if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
 	    ir.rm &= 0x3;
 	  I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);

--------------040602010307040708040204--