From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Hui Zhu <teawater@gmail.com>
Subject: [RFA] Fix probable typo in i386_process_record
Date: Sat, 10 Oct 2009 01:01:00 -0000 [thread overview]
Message-ID: <4ACFDBDC.1090500@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 68 bytes --]
Hui, I'm *pretty* sure I got this right, but you'd better confirm:
[-- Attachment #2: typo.txt --]
[-- Type: text/plain, Size: 637 bytes --]
2009-10-09 Michael Snyder <msnyder@vmware.com>
* i386-tdep.c (i386_process_record): Or-equals, not not-equals.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.288
diff -u -p -r1.288 i386-tdep.c
--- i386-tdep.c 28 Sep 2009 07:11:36 -0000 1.288
+++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
@@ -4146,7 +4146,7 @@ reswitch:
return -1;
if (ir.mod == 3)
{
- ir.rm != ir.rex_b;
+ ir.rm |= ir.rex_b;
if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
ir.rm &= 0x3;
I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
next reply other threads:[~2009-10-10 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 1:01 Michael Snyder [this message]
2009-10-10 5:51 ` Hui Zhu
2009-10-11 3:21 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACFDBDC.1090500@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox