Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix probable typo in i386_process_record
Date: Sat, 10 Oct 2009 05:51:00 -0000	[thread overview]
Message-ID: <daef60380910092251u36ddb67ayfd3310268ca48e99@mail.gmail.com> (raw)
In-Reply-To: <4ACFDBDC.1090500@vmware.com>

I think this patch is OK.  Thanks a lot.

Hui

On Sat, Oct 10, 2009 at 08:57, Michael Snyder <msnyder@vmware.com> wrote:
> Hui, I'm *pretty* sure I got this right, but you'd better confirm:
>
>
> 2009-10-09  Michael Snyder  <msnyder@vmware.com>
>
>        * i386-tdep.c (i386_process_record): Or-equals, not not-equals.
>
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.288
> diff -u -p -r1.288 i386-tdep.c
> --- i386-tdep.c 28 Sep 2009 07:11:36 -0000      1.288
> +++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
> @@ -4146,7 +4146,7 @@ reswitch:
>        return -1;
>       if (ir.mod == 3)
>        {
> -         ir.rm != ir.rex_b;
> +         ir.rm |= ir.rex_b;
>          if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
>            ir.rm &= 0x3;
>          I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
>
>


  reply	other threads:[~2009-10-10  5:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10  1:01 Michael Snyder
2009-10-10  5:51 ` Hui Zhu [this message]
2009-10-11  3:21   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380910092251u36ddb67ayfd3310268ca48e99@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox