From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8234 invoked by alias); 10 Oct 2009 05:51:49 -0000
Received: (qmail 8225 invoked by uid 22791); 10 Oct 2009 05:51:48 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f202.google.com (HELO mail-px0-f202.google.com) (209.85.216.202)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Oct 2009 05:51:44 +0000
Received: by pxi40 with SMTP id 40so7925603pxi.24         for <gdb-patches@sourceware.org>; Fri, 09 Oct 2009 22:51:43 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.25.39 with SMTP id c39mr277951wfj.10.1255153903076; Fri,  	09 Oct 2009 22:51:43 -0700 (PDT)
In-Reply-To: <4ACFDBDC.1090500@vmware.com>
References: <4ACFDBDC.1090500@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sat, 10 Oct 2009 05:51:00 -0000
Message-ID: <daef60380910092251u36ddb67ayfd3310268ca48e99@mail.gmail.com>
Subject: Re: [RFA] Fix probable typo in i386_process_record
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00203.txt.bz2

I think this patch is OK.  Thanks a lot.

Hui

On Sat, Oct 10, 2009 at 08:57, Michael Snyder <msnyder@vmware.com> wrote:
> Hui, I'm *pretty* sure I got this right, but you'd better confirm:
>
>
> 2009-10-09 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* i386-tdep.c (i386_process_record): Or-equals, not not-eq=
uals.
>
> Index: i386-tdep.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.288
> diff -u -p -r1.288 i386-tdep.c
> --- i386-tdep.c 28 Sep 2009 07:11:36 -0000 =A0 =A0 =A01.288
> +++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
> @@ -4146,7 +4146,7 @@ reswitch:
> =A0 =A0 =A0 =A0return -1;
> =A0 =A0 =A0 if (ir.mod =3D=3D 3)
> =A0 =A0 =A0 =A0{
> - =A0 =A0 =A0 =A0 ir.rm !=3D ir.rex_b;
> + =A0 =A0 =A0 =A0 ir.rm |=3D ir.rex_b;
> =A0 =A0 =A0 =A0 =A0if (ir.ot =3D=3D OT_BYTE && !ir.regmap[X86_RECORD_R8_R=
EGNUM])
> =A0 =A0 =A0 =A0 =A0 =A0ir.rm &=3D 0x3;
> =A0 =A0 =A0 =A0 =A0I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
>
>