Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: arm_addr_bits_remove
Date: Thu, 24 Jan 2008 13:39:00 -0000	[thread overview]
Message-ID: <4798871B.4080207@codesourcery.com> (raw)
In-Reply-To: <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Jim Blandy wrote:
> On Jan 23, 2008 8:53 PM, Pedro Alves wrote:
>> Would a patch removing this be more acceptable then?
> 
> I'd certainly be more enthusiastic about it.  :)
> 

Well, then, here's one for the review-enthusiasts amongst us. :-)

Thanks Jim.

OK ?

-- 
Pedro Alves

[-- Attachment #2: record_line.diff --]
[-- Type: text/x-diff, Size: 802 bytes --]

2008-01-24  Pedro Alves  <pedro@codesourcery.com>

	* buildsym.c (record_line): Don't try to strip unused addr bits.

---
 gdb/buildsym.c |    2 --
 1 files changed, 2 deletions(-)

Index: gdb-trunk/gdb/buildsym.c
===================================================================
--- gdb-trunk.orig/gdb/buildsym.c	2008-01-09 10:53:49.000000000 -0800
+++ gdb-trunk/gdb/buildsym.c	2008-01-24 04:30:26.000000000 -0800
@@ -794,8 +794,6 @@ record_line (struct subfile *subfile, in
 		      * sizeof (struct linetable_entry))));
     }
 
-  pc = gdbarch_addr_bits_remove (current_gdbarch, pc);
-
   /* Normally, we treat lines as unsorted.  But the end of sequence
      marker is special.  We sort line markers at the same PC by line
      number, so end of sequence markers (which have line == 0) appear

  parent reply	other threads:[~2008-01-24 12:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 21:17 arm_addr_bits_remove Pedro Alves
2008-01-22 23:26 ` arm_addr_bits_remove Jim Blandy
2008-01-23 14:45   ` arm_addr_bits_remove Pedro Alves
2008-01-23 19:22     ` arm_addr_bits_remove Jim Blandy
2008-01-23 19:29       ` arm_addr_bits_remove Daniel Jacobowitz
2008-01-23 21:12         ` arm_addr_bits_remove Jim Blandy
2008-01-24  4:54           ` arm_addr_bits_remove Pedro Alves
2008-01-24  7:35             ` arm_addr_bits_remove Jim Blandy
2008-01-24  6:30               ` arm_addr_bits_remove Jim Blandy
2008-01-24 13:39               ` Pedro Alves [this message]
2008-01-24 14:45                 ` arm_addr_bits_remove Daniel Jacobowitz
2008-01-24 14:56                   ` arm_addr_bits_remove Pedro Alves
2008-01-24 16:53                     ` arm_addr_bits_remove Jim Blandy
2008-01-24 17:01                       ` arm_addr_bits_remove Pedro Alves
2008-01-24 22:19                   ` arm_addr_bits_remove Joel Brobecker
2008-01-25  0:11                     ` arm_addr_bits_remove Pedro Alves
2008-01-25  4:13                       ` arm_addr_bits_remove Joel Brobecker
2008-01-25  9:56                         ` arm_addr_bits_remove Carlos O'Donell
2008-01-25 21:24                           ` arm_addr_bits_remove John David Anglin
2008-01-25 22:14                             ` arm_addr_bits_remove Jim Blandy
2008-01-26 13:57                               ` arm_addr_bits_remove John David Anglin
2008-02-04 10:16                     ` arm_addr_bits_remove Maciej W. Rozycki
2008-02-04 13:41                       ` arm_addr_bits_remove Daniel Jacobowitz
2008-02-04 14:45                         ` arm_addr_bits_remove Maciej W. Rozycki
2008-02-04 14:51                           ` arm_addr_bits_remove Daniel Jacobowitz
2008-02-04 15:20                             ` arm_addr_bits_remove Maciej W. Rozycki
2008-01-24 17:18               ` arm_addr_bits_remove Mark Kettenis
2008-01-24 17:50                 ` arm_addr_bits_remove Joel Brobecker
2008-01-24 21:33                   ` arm_addr_bits_remove Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4798871B.4080207@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox