From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13351 invoked by alias); 24 Jan 2008 12:41:41 -0000 Received: (qmail 13335 invoked by uid 22791); 24 Jan 2008 12:41:41 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Jan 2008 12:41:17 +0000 Received: (qmail 26186 invoked from network); 24 Jan 2008 12:41:14 -0000 Received: from unknown (HELO ?192.168.0.100?) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jan 2008 12:41:14 -0000 Message-ID: <4798871B.4080207@codesourcery.com> Date: Thu, 24 Jan 2008 13:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20071023 Thunderbird/1.5.0.14pre Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Jim Blandy CC: gdb-patches Subject: Re: arm_addr_bits_remove References: <47965D31.3040602@codesourcery.com> <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> <479752C8.8030201@portugalmail.pt> <8f2776cb0801231121r3fe9aea0q6f3c3d6887fcb251@mail.gmail.com> <20080123192842.GA22477@caradoc.them.org> <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> <479819E2.1030603@portugalmail.pt> <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com> In-Reply-To: <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------050907040407020003000408" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00582.txt.bz2 This is a multi-part message in MIME format. --------------050907040407020003000408 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 280 Jim Blandy wrote: > On Jan 23, 2008 8:53 PM, Pedro Alves wrote: >> Would a patch removing this be more acceptable then? > > I'd certainly be more enthusiastic about it. :) > Well, then, here's one for the review-enthusiasts amongst us. :-) Thanks Jim. OK ? -- Pedro Alves --------------050907040407020003000408 Content-Type: text/x-diff; name="record_line.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="record_line.diff" Content-length: 802 2008-01-24 Pedro Alves * buildsym.c (record_line): Don't try to strip unused addr bits. --- gdb/buildsym.c | 2 -- 1 files changed, 2 deletions(-) Index: gdb-trunk/gdb/buildsym.c =================================================================== --- gdb-trunk.orig/gdb/buildsym.c 2008-01-09 10:53:49.000000000 -0800 +++ gdb-trunk/gdb/buildsym.c 2008-01-24 04:30:26.000000000 -0800 @@ -794,8 +794,6 @@ record_line (struct subfile *subfile, in * sizeof (struct linetable_entry)))); } - pc = gdbarch_addr_bits_remove (current_gdbarch, pc); - /* Normally, we treat lines as unsorted. But the end of sequence marker is special. We sort line markers at the same PC by line number, so end of sequence markers (which have line == 0) appear --------------050907040407020003000408--