From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Adam Fedor <fedor@doc.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Objective-C language support.
Date: Wed, 23 Oct 2002 12:23:00 -0000 [thread overview]
Message-ID: <3DB6F744.410DB743@redhat.com> (raw)
In-Reply-To: <3DB4811E.5080106@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
Andrew Cagney wrote:
>
> > - error ("no args, no `this'");
> >> + error ("no args, no %s", name);
>
> Michael,
>
> This changes GDB's behavior. Instead of printing:
>
> no args, no `this'
> it will print
> no args, no this
>
> I don't think GDB's output should be changed in this way.
> (I'm suprized that running the testsuite didn't detect this).
Hi Andrew,
I corrected this with the patch below. I did not add a new test,
because I cannot find a way to invoke this error message. ;-/
Michael
[-- Attachment #2: this.diff --]
[-- Type: text/plain, Size: 697 bytes --]
2002-10-23 Michael Snyder <msnyder@redhat.com>
* valops.c (value_of_local): Restore quotes in error message.
Index: valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.76
diff -p -r1.76 valops.c
*** valops.c 14 Oct 2002 02:02:42 -0000 1.76
--- valops.c 23 Oct 2002 19:21:12 -0000
*************** value_of_local (const char *name, int co
*** 3340,3346 ****
if (i <= 0)
{
if (complain)
! error ("no args, no %s", name);
else
return 0;
}
--- 3340,3346 ----
if (i <= 0)
{
if (complain)
! error ("no args, no '%s'", name);
else
return 0;
}
next prev parent reply other threads:[~2002-10-23 19:23 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 8:24 Adam Fedor
2002-09-18 10:50 ` Michael Snyder
2002-09-18 11:57 ` Michael Snyder
2002-09-18 11:57 ` Andrew Cagney
2002-09-18 12:04 ` Michael Snyder
2002-09-18 12:14 ` Andrew Cagney
2002-09-18 12:17 ` Michael Snyder
2002-09-18 13:51 ` Adam Fedor
2002-09-18 15:00 ` Michael Snyder
2002-09-18 15:19 ` Adam Fedor
2002-09-18 15:25 ` Andrew Cagney
2002-09-18 11:59 ` Daniel Berlin
2002-09-18 13:31 ` Adam Fedor
2002-09-18 14:03 ` Andrew Cagney
2002-10-08 16:36 ` Michael Snyder
2002-10-11 19:29 ` Adam Fedor
2002-10-08 16:42 ` Michael Snyder
2002-10-11 19:44 ` Adam Fedor
2002-10-21 15:18 ` Andrew Cagney
2002-10-21 15:27 ` Michael Snyder
2002-10-08 16:45 ` Michael Snyder
2002-10-11 19:39 ` Adam Fedor
2002-10-08 16:51 ` Michael Snyder
2002-10-14 13:06 ` Jim Blandy
2002-10-21 15:28 ` Andrew Cagney
2002-10-22 17:04 ` Michael Snyder
2002-10-22 18:42 ` Elena Zannoni
2002-10-08 16:58 ` Michael Snyder
2002-10-14 19:18 ` Adam Fedor
2002-10-21 15:31 ` Andrew Cagney
2002-10-08 17:01 ` Michael Snyder
2002-10-14 13:08 ` Jim Blandy
2002-10-18 10:06 ` Adam Fedor
2002-10-08 17:05 ` Michael Snyder
2002-10-14 13:14 ` Jim Blandy
2002-10-14 20:09 ` Adam Fedor
2002-10-18 14:24 ` Elena Zannoni
2002-10-22 5:49 ` Jim Blandy
2002-10-22 14:23 ` Michael Snyder
2002-10-21 15:25 ` Andrew Cagney
2002-11-07 23:44 ` Jim Blandy
2002-11-08 7:16 ` Elena Zannoni
2002-10-08 17:07 ` Michael Snyder
2002-10-11 20:06 ` Adam Fedor
2002-10-08 17:14 ` Michael Snyder
2002-10-13 18:51 ` Adam Fedor
2002-10-08 17:16 ` Michael Snyder
2002-10-12 11:37 ` Adam Fedor
2002-10-08 17:19 ` Michael Snyder
2002-10-14 19:33 ` Adam Fedor
2002-10-16 12:16 ` Michael Snyder
2002-10-08 17:30 ` Michael Snyder
2002-10-13 19:06 ` Adam Fedor
2002-10-21 15:35 ` Andrew Cagney
2002-10-21 16:19 ` Michael Snyder
2002-10-23 12:23 ` Michael Snyder [this message]
2002-10-23 12:36 ` Andrew Cagney
2002-10-23 13:10 ` Daniel Jacobowitz
2002-10-23 14:37 ` Michael Snyder
2002-10-23 14:35 ` Michael Snyder
2002-10-08 17:34 ` Michael Snyder
2002-10-13 19:12 ` Adam Fedor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB6F744.410DB743@redhat.com \
--to=msnyder@redhat.com \
--cc=ac131313@redhat.com \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox