Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Adam Fedor <fedor@doc.com>
Cc: gdb-patches@sources.redhat.com, jimb@redhat.com
Subject: Re: [PATCH] Objective-C language support.
Date: Tue, 08 Oct 2002 17:01:00 -0000	[thread overview]
Message-ID: <3DA37187.57F232FE@redhat.com> (raw)
In-Reply-To: <3D889A97.90202@doc.com>

Adam Fedor wrote:
> 
> This patch adds Objective-C language support to gdb based upon a patch
> provided by Apple Computer Inc from their version of gdb. Note that the
> patch only contains changes to existing files. New files (objc-lang.h,
> objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at
> 
> ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz
> 

Jim, could you take a quick look at this small change?
[Adam, the comment needs a period followed by two spaces.]  


>         * elfread.c (elf_symtab_read): Skip ObjC symbols.

> Index: gdb/elfread.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/elfread.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 elfread.c
> --- gdb/elfread.c       24 Jul 2002 23:51:35 -0000      1.23
> +++ gdb/elfread.c       17 Sep 2002 19:29:59 -0000
> @@ -349,7 +349,12 @@ elf_symtab_read (struct objfile *objfile
>                 }
>               else if (sym->section->flags & SEC_CODE)
>                 {
> -                 if (sym->flags & BSF_GLOBAL)
> +                 if (sym->name[0] == '.' && (strncmp (sym->name + 1, "objc_", 4) == 0))
> +                   {
> +                     /* Looks like an Objective-C special symbol */
> +                     continue;
> +                   }
> +                 else if (sym->flags & BSF_GLOBAL)
>                     {
>                       ms_type = mst_text;
>                     }


  parent reply	other threads:[~2002-10-09  0:01 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-18  8:24 Adam Fedor
2002-09-18 10:50 ` Michael Snyder
2002-09-18 11:57   ` Michael Snyder
2002-09-18 11:57   ` Andrew Cagney
2002-09-18 12:04     ` Michael Snyder
2002-09-18 12:14       ` Andrew Cagney
2002-09-18 12:17         ` Michael Snyder
2002-09-18 13:51           ` Adam Fedor
2002-09-18 15:00             ` Michael Snyder
2002-09-18 15:19               ` Adam Fedor
2002-09-18 15:25               ` Andrew Cagney
2002-09-18 11:59   ` Daniel Berlin
2002-09-18 13:31   ` Adam Fedor
2002-09-18 14:03 ` Andrew Cagney
2002-10-08 16:36 ` Michael Snyder
2002-10-11 19:29   ` Adam Fedor
2002-10-08 16:42 ` Michael Snyder
2002-10-11 19:44   ` Adam Fedor
2002-10-21 15:18   ` Andrew Cagney
2002-10-21 15:27     ` Michael Snyder
2002-10-08 16:45 ` Michael Snyder
2002-10-11 19:39   ` Adam Fedor
2002-10-08 16:51 ` Michael Snyder
2002-10-14 13:06   ` Jim Blandy
2002-10-21 15:28     ` Andrew Cagney
2002-10-22 17:04       ` Michael Snyder
2002-10-22 18:42         ` Elena Zannoni
2002-10-08 16:58 ` Michael Snyder
2002-10-14 19:18   ` Adam Fedor
2002-10-21 15:31   ` Andrew Cagney
2002-10-08 17:01 ` Michael Snyder [this message]
2002-10-14 13:08   ` Jim Blandy
2002-10-18 10:06     ` Adam Fedor
2002-10-08 17:05 ` Michael Snyder
2002-10-14 13:14   ` Jim Blandy
2002-10-14 20:09     ` Adam Fedor
2002-10-18 14:24       ` Elena Zannoni
2002-10-22  5:49         ` Jim Blandy
2002-10-22 14:23           ` Michael Snyder
2002-10-21 15:25       ` Andrew Cagney
2002-11-07 23:44       ` Jim Blandy
2002-11-08  7:16         ` Elena Zannoni
2002-10-08 17:07 ` Michael Snyder
2002-10-11 20:06   ` Adam Fedor
2002-10-08 17:14 ` Michael Snyder
2002-10-13 18:51   ` Adam Fedor
2002-10-08 17:16 ` Michael Snyder
2002-10-12 11:37   ` Adam Fedor
2002-10-08 17:19 ` Michael Snyder
2002-10-14 19:33   ` Adam Fedor
2002-10-16 12:16     ` Michael Snyder
2002-10-08 17:30 ` Michael Snyder
2002-10-13 19:06   ` Adam Fedor
2002-10-21 15:35   ` Andrew Cagney
2002-10-21 16:19     ` Michael Snyder
2002-10-23 12:23     ` Michael Snyder
2002-10-23 12:36       ` Andrew Cagney
2002-10-23 13:10         ` Daniel Jacobowitz
2002-10-23 14:37           ` Michael Snyder
2002-10-23 14:35         ` Michael Snyder
2002-10-08 17:34 ` Michael Snyder
2002-10-13 19:12   ` Adam Fedor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DA37187.57F232FE@redhat.com \
    --to=msnyder@redhat.com \
    --cc=fedor@doc.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox