From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19322-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 918 invoked by alias); 9 Oct 2002 00:01:31 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 911 invoked from network); 9 Oct 2002 00:01:31 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 9 Oct 2002 00:01:31 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g98NfoX18862
	for <gdb-patches@sources.redhat.com>; Tue, 8 Oct 2002 19:41:50 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9901Il01652;
	Tue, 8 Oct 2002 20:01:18 -0400
Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9901HN29958;
	Tue, 8 Oct 2002 17:01:17 -0700
Message-ID: <3DA37187.57F232FE@redhat.com>
Date: Tue, 08 Oct 2002 17:01:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Adam Fedor <fedor@doc.com>
CC: gdb-patches@sources.redhat.com, jimb@redhat.com
Subject: Re: [PATCH] Objective-C language support.
References: <3D889A97.90202@doc.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-10/txt/msg00194.txt.bz2

Adam Fedor wrote:
> 
> This patch adds Objective-C language support to gdb based upon a patch
> provided by Apple Computer Inc from their version of gdb. Note that the
> patch only contains changes to existing files. New files (objc-lang.h,
> objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at
> 
> ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz
> 

Jim, could you take a quick look at this small change?
[Adam, the comment needs a period followed by two spaces.]  


>         * elfread.c (elf_symtab_read): Skip ObjC symbols.

> Index: gdb/elfread.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/elfread.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 elfread.c
> --- gdb/elfread.c       24 Jul 2002 23:51:35 -0000      1.23
> +++ gdb/elfread.c       17 Sep 2002 19:29:59 -0000
> @@ -349,7 +349,12 @@ elf_symtab_read (struct objfile *objfile
>                 }
>               else if (sym->section->flags & SEC_CODE)
>                 {
> -                 if (sym->flags & BSF_GLOBAL)
> +                 if (sym->name[0] == '.' && (strncmp (sym->name + 1, "objc_", 4) == 0))
> +                   {
> +                     /* Looks like an Objective-C special symbol */
> +                     continue;
> +                   }
> +                 else if (sym->flags & BSF_GLOBAL)
>                     {
>                       ms_type = mst_text;
>                     }