From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19596-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 2924 invoked by alias); 23 Oct 2002 19:23:52 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2916 invoked from network); 23 Oct 2002 19:23:51 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 23 Oct 2002 19:23:51 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9NJ2Qw12949
	for <gdb-patches@sources.redhat.com>; Wed, 23 Oct 2002 15:02:26 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9NJNnl08704;
	Wed, 23 Oct 2002 15:23:49 -0400
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9NJNmD22002;
	Wed, 23 Oct 2002 12:23:48 -0700
Message-ID: <3DB6F744.410DB743@redhat.com>
Date: Wed, 23 Oct 2002 12:23:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@redhat.com>
CC: Adam Fedor <fedor@doc.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Objective-C language support.
References: <3D889A97.90202@doc.com> <3DA37857.466240D9@redhat.com> <3DB4811E.5080106@redhat.com>
Content-Type: multipart/mixed;
 boundary="------------4547D5E5F090E1A85F722987"
X-SW-Source: 2002-10/txt/msg00468.txt.bz2

This is a multi-part message in MIME format.
--------------4547D5E5F090E1A85F722987
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-length: 534

Andrew Cagney wrote:
> 
> > -       error ("no args, no `this'");
> >> +       error ("no args, no %s", name);
> 
> Michael,
> 
> This changes GDB's behavior.  Instead of printing:
> 
>         no args, no `this'
> it will print
>         no args, no this
> 
> I don't think GDB's output should be changed in this way.
> (I'm suprized that running the testsuite didn't detect this).

Hi Andrew, 

I corrected this with the patch below.  I did not add a new test,
because I cannot find a way to invoke this error message.  ;-/

Michael
--------------4547D5E5F090E1A85F722987
Content-Type: text/plain; charset=us-ascii;
 name="this.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="this.diff"
Content-length: 697

2002-10-23  Michael Snyder  <msnyder@redhat.com>

	* valops.c (value_of_local): Restore quotes in error message.

Index: valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.76
diff -p -r1.76 valops.c
*** valops.c	14 Oct 2002 02:02:42 -0000	1.76
--- valops.c	23 Oct 2002 19:21:12 -0000
*************** value_of_local (const char *name, int co
*** 3340,3346 ****
    if (i <= 0)
      {
        if (complain)
! 	error ("no args, no %s", name);
        else
  	return 0;
      }
--- 3340,3346 ----
    if (i <= 0)
      {
        if (complain)
! 	error ("no args, no '%s'", name);
        else
  	return 0;
      }

--------------4547D5E5F090E1A85F722987--