Re: RFC: Avoid calling XXX_skip_prologue for assembly code

[Fernando Nasser <fnasser@redhat.com>]

Fred,

May I suggest the creation of a set/show command to allow this
to be deactivated?

set assembly-skip-prolog

I don't mind if the default is off, I can put it in my .gdbinit file.
But disallowing it in a hardwired way will punish anyone who followed
the linkage conventions to be able to use backtrace.

I strongly object to this patch unless accompanied by a set/show 
command.  (But I am not the maintainer.)

Regards,
Fernando


Fred Fish wrote:
> 
> (Note: I'm revisiting an old patch submitted in Oct 2001)
> 
> > Would you be willing to try gdb.asm/asm-source.exp against a D10V sim
> > with this change?  I'm pretty sure your change is going to break that
> > test.  If so, you could fix the failure by changing the test to set
> > the breakpoint after the `enter' sequences.
> 
> I just built a D10V toolchain with a recent gdb, and ran the full
> testsuite with and without this change.  There was no difference in
> the testsuite results.  All of the asm-source.exp tests passed both
> with and without this patch installed.
> 
> OK to check in this patch?
> 
> -Fred

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9