Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fred Fish <fnf@gofish.ninemoons.com>
To: ac131313@cygnus.com (Andrew Cagney)
Cc: jimb@cygnus.com (Jim Blandy),
	fnf@ninemoons.com, gdb-patches@sources.redhat.com
Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code
Date: Thu, 11 Oct 2001 19:23:00 -0000	[thread overview]
Message-ID: <200110120222.f9C2M6t24897@gofish.ninemoons.com> (raw)
In-Reply-To: <3BC61FD7.5040504@cygnus.com>

> Does anyone know the motivation behind the patch?

I ran into a target for which the skip_prologue code did not behave
correctly for assembly language functions.  The details are hazy now
but as I recall the skip prologue function always returned PC+2 in
such cases, instead of just returning PC.  In looking at some of the
other XXX_skip_prologue functions it appeared to me that they would
have the same problems under similar conditions.  Ideally we would
just fix all the skip_prologue functions to do the right thing, but then
I began to question why we were even calling skip_prologue anyway on
functions that were already known to have been written in assembly
language.

-Fred


  reply	other threads:[~2001-10-11 19:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-05 12:55 Fred Fish
2001-10-11 13:13 ` Jim Blandy
2001-10-11 13:37   ` Andrew Cagney
2001-10-11 13:22 ` Jim Blandy
2001-10-11 14:17 ` Jim Blandy
2001-10-11 15:40   ` Andrew Cagney
2001-10-11 19:23     ` Fred Fish [this message]
2002-04-11 16:30   ` Fred Fish
2002-04-12  8:34     ` Fernando Nasser
2002-04-12  9:41       ` Fred Fish
2002-04-12  9:47         ` Fernando Nasser
     [not found] ` <fnf@www.ninemoons.com>
2001-10-05 13:58   ` Kevin Buettner
2001-10-27 16:38   ` [RFA] Change auto-solib-add to boolean, add auto-solib-limit Kevin Buettner
2001-10-29 22:14   ` [RFA] Use 1024*1024 for a megabyte, not 1000000 Kevin Buettner
2001-10-30 17:22   ` [RFA] Fix a couple of auto-solib-add problems Kevin Buettner
2001-10-27 12:50 [RFA] Change auto-solib-add to boolean, add auto-solib-limit Fred Fish
2001-10-27 17:01 ` Elena Zannoni
2001-10-28  1:54 ` Eli Zaretskii
2001-10-29 20:35 [RFA] Use 1024*1024 for a megabyte, not 1000000 Fred Fish
2001-10-30 15:35 [RFA] Fix a couple of auto-solib-add problems Fred Fish
2001-10-31  4:02 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200110120222.f9C2M6t24897@gofish.ninemoons.com \
    --to=fnf@gofish.ninemoons.com \
    --cc=ac131313@cygnus.com \
    --cc=fnf@ninemoons.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox