From: Fred Fish <fnf@fishpond.ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@ninemoons.com
Subject: RFC: Avoid calling XXX_skip_prologue for assembly code
Date: Fri, 05 Oct 2001 12:55:00 -0000 [thread overview]
Message-ID: <200110051954.f95JsNn07270@fishpond.ninemoons.com> (raw)
Does anyone have any issues with the attached patch?
There is little point in attempting to skip over prologues if we
already know for a fact that the source language is assembly.
In fact, attempting to do so may actually be incorrect if the user has
taken the output of the compiler, used that as the basis for his code,
and hand optimized it in some way to produce an assembly version.
There could still be prologue code in the hand crafted version.
Another way to handle this issue would be to have each of the
"XXX_skip_prologue" functions in the various XXX-tdep.c files do their
own checking first to see if the language is assembly, but they don't
have easy access to that info, and each of them would have to do
something similar to this patch anyway, so it seems more logical to
just do the test in one place.
-Fred
==================================================================
2001-10-05 Fred Fish <fnf@cygnus.com>
* symtab.c (find_function_start_sal): Do not attempt to skip over
prologues for assembly functions.
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.42
diff -u -p -r1.42 symtab.c
--- symtab.c 2001/07/07 17:19:50 1.42
+++ symtab.c 2001/10/05 19:42:05
@@ -2031,7 +2031,7 @@ find_function_start_sal (struct symbol *
pc = BLOCK_START (SYMBOL_BLOCK_VALUE (sym));
fixup_symbol_section (sym, NULL);
- if (funfirstline)
+ if (funfirstline && SYMBOL_LANGUAGE(sym) != language_asm)
{ /* skip "first line" of function (which is actually its prologue) */
asection *section = SYMBOL_BFD_SECTION (sym);
/* If function is in an unmapped overlay, use its unmapped LMA
next reply other threads:[~2001-10-05 12:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 12:55 Fred Fish [this message]
2001-10-11 13:13 ` Jim Blandy
2001-10-11 13:37 ` Andrew Cagney
2001-10-11 13:22 ` Jim Blandy
2001-10-11 14:17 ` Jim Blandy
2001-10-11 15:40 ` Andrew Cagney
2001-10-11 19:23 ` Fred Fish
2002-04-11 16:30 ` Fred Fish
2002-04-12 8:34 ` Fernando Nasser
2002-04-12 9:41 ` Fred Fish
2002-04-12 9:47 ` Fernando Nasser
[not found] ` <fnf@www.ninemoons.com>
2001-10-05 13:58 ` Kevin Buettner
2001-10-27 16:38 ` [RFA] Change auto-solib-add to boolean, add auto-solib-limit Kevin Buettner
2001-10-29 22:14 ` [RFA] Use 1024*1024 for a megabyte, not 1000000 Kevin Buettner
2001-10-30 17:22 ` [RFA] Fix a couple of auto-solib-add problems Kevin Buettner
2001-10-27 12:50 [RFA] Change auto-solib-add to boolean, add auto-solib-limit Fred Fish
2001-10-27 17:01 ` Elena Zannoni
2001-10-28 1:54 ` Eli Zaretskii
2001-10-29 20:35 [RFA] Use 1024*1024 for a megabyte, not 1000000 Fred Fish
2001-10-30 15:35 [RFA] Fix a couple of auto-solib-add problems Fred Fish
2001-10-31 4:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200110051954.f95JsNn07270@fishpond.ninemoons.com \
--to=fnf@fishpond.ninemoons.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox