Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fernando Nasser <fnasser@redhat.com>
To: fnf@redhat.com
Cc: jimb@redhat.com, fnf@ninemoons.com,
	gdb-patches@sources.redhat.com, Andrew Cagney <cagney@cygnus.com>,
	Michael Snyder <msnyder@cygnus.com>
Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code
Date: Fri, 12 Apr 2002 09:47:00 -0000	[thread overview]
Message-ID: <3CB70EF9.2FB421AA@redhat.com> (raw)
In-Reply-To: <200204121636.g3CGaGk08573@fishpond.ninemoons.com>

Fred Fish wrote:
> 
> > I strongly object to this patch unless accompanied by a set/show
> > command.  (But I am not the maintainer.)
> 
> There seems to be enough issues with this patch that perhaps I should
> just withdraw it.  The alternate solution is to fix the skip_prologue
> functions that don't do the right thing with assembly language
> prologues that don't follow normal conventions.  The original
> motivation for this patch was an architecture where skip_prologue
> always returned PC+2 regardless of what it found.
> 

It should not be too difficult to add a set/show variable.

But if you can't spare the time, and if people agree with this
solution, you could just enter your patch in the bug database
and say it is pending the creation of the switch.  Eventually
someone will get at the bug entry and do it.

Regards,
Fernando

P.S.: Note that I agree with the patch, if controlled by a behavior 
variable.  My objection is just against hardwiring it.

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


  reply	other threads:[~2002-04-12 16:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-05 12:55 Fred Fish
2001-10-11 13:13 ` Jim Blandy
2001-10-11 13:37   ` Andrew Cagney
2001-10-11 13:22 ` Jim Blandy
2001-10-11 14:17 ` Jim Blandy
2001-10-11 15:40   ` Andrew Cagney
2001-10-11 19:23     ` Fred Fish
2002-04-11 16:30   ` Fred Fish
2002-04-12  8:34     ` Fernando Nasser
2002-04-12  9:41       ` Fred Fish
2002-04-12  9:47         ` Fernando Nasser [this message]
     [not found] ` <fnf@www.ninemoons.com>
2001-10-05 13:58   ` Kevin Buettner
2001-10-27 16:38   ` [RFA] Change auto-solib-add to boolean, add auto-solib-limit Kevin Buettner
2001-10-29 22:14   ` [RFA] Use 1024*1024 for a megabyte, not 1000000 Kevin Buettner
2001-10-30 17:22   ` [RFA] Fix a couple of auto-solib-add problems Kevin Buettner
2001-10-27 12:50 [RFA] Change auto-solib-add to boolean, add auto-solib-limit Fred Fish
2001-10-27 17:01 ` Elena Zannoni
2001-10-28  1:54 ` Eli Zaretskii
2001-10-29 20:35 [RFA] Use 1024*1024 for a megabyte, not 1000000 Fred Fish
2001-10-30 15:35 [RFA] Fix a couple of auto-solib-add problems Fred Fish
2001-10-31  4:02 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CB70EF9.2FB421AA@redhat.com \
    --to=fnasser@redhat.com \
    --cc=cagney@cygnus.com \
    --cc=fnf@ninemoons.com \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox