From: Kevin Buettner <kevinb@cygnus.com>
To: fnf@ninemoons.com, gdb-patches@sources.redhat.com
Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code
Date: Fri, 05 Oct 2001 13:58:00 -0000 [thread overview]
Message-ID: <1011005205818.ZM29107@ocotillo.lan> (raw)
In-Reply-To: <fnf@www.ninemoons.com>
On Oct 5, 12:54pm, Fred Fish wrote:
> Does anyone have any issues with the attached patch?
>
> There is little point in attempting to skip over prologues if we
> already know for a fact that the source language is assembly.
>
> In fact, attempting to do so may actually be incorrect if the user has
> taken the output of the compiler, used that as the basis for his code,
> and hand optimized it in some way to produce an assembly version.
> There could still be prologue code in the hand crafted version.
[...]
> * symtab.c (find_function_start_sal): Do not attempt to skip over
> prologues for assembly functions.
The patch looks good to me. (Please note that I'm not the maintainer
though.)
Kevin
next prev parent reply other threads:[~2001-10-05 13:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 12:55 Fred Fish
2001-10-11 13:13 ` Jim Blandy
2001-10-11 13:37 ` Andrew Cagney
2001-10-11 13:22 ` Jim Blandy
2001-10-11 14:17 ` Jim Blandy
2001-10-11 15:40 ` Andrew Cagney
2001-10-11 19:23 ` Fred Fish
2002-04-11 16:30 ` Fred Fish
2002-04-12 8:34 ` Fernando Nasser
2002-04-12 9:41 ` Fred Fish
2002-04-12 9:47 ` Fernando Nasser
[not found] ` <fnf@www.ninemoons.com>
2001-10-05 13:58 ` Kevin Buettner [this message]
2001-10-27 16:38 ` [RFA] Change auto-solib-add to boolean, add auto-solib-limit Kevin Buettner
2001-10-29 22:14 ` [RFA] Use 1024*1024 for a megabyte, not 1000000 Kevin Buettner
2001-10-30 17:22 ` [RFA] Fix a couple of auto-solib-add problems Kevin Buettner
2001-10-27 12:50 [RFA] Change auto-solib-add to boolean, add auto-solib-limit Fred Fish
2001-10-27 17:01 ` Elena Zannoni
2001-10-28 1:54 ` Eli Zaretskii
2001-10-29 20:35 [RFA] Use 1024*1024 for a megabyte, not 1000000 Fred Fish
2001-10-30 15:35 [RFA] Fix a couple of auto-solib-add problems Fred Fish
2001-10-31 4:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011005205818.ZM29107@ocotillo.lan \
--to=kevinb@cygnus.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox