From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: fnf@ninemoons.com, gdb-patches@sources.redhat.com Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code Date: Fri, 05 Oct 2001 13:58:00 -0000 Message-id: <1011005205818.ZM29107@ocotillo.lan> References: <200110051954.f95JsNn07270@fishpond.ninemoons.com> X-SW-Source: 2001-10/msg00092.html On Oct 5, 12:54pm, Fred Fish wrote: > Does anyone have any issues with the attached patch? > > There is little point in attempting to skip over prologues if we > already know for a fact that the source language is assembly. > > In fact, attempting to do so may actually be incorrect if the user has > taken the output of the compiler, used that as the basis for his code, > and hand optimized it in some way to produce an assembly version. > There could still be prologue code in the hand crafted version. [...] > * symtab.c (find_function_start_sal): Do not attempt to skip over > prologues for assembly functions. The patch looks good to me. (Please note that I'm not the maintainer though.) Kevin