From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23886 invoked by alias); 12 Apr 2002 15:34:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23878 invoked from network); 12 Apr 2002 15:34:17 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 12 Apr 2002 15:34:17 -0000 Received: from redhat.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA02926; Fri, 12 Apr 2002 08:34:14 -0700 (PDT) Message-ID: <3CB6FDCA.10E6C9F5@redhat.com> Date: Fri, 12 Apr 2002 08:34:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Accept-Language: en MIME-Version: 1.0 To: fnf@redhat.com CC: jimb@redhat.com, fnf@ninemoons.com, gdb-patches@sources.redhat.com, Andrew Cagney , Michael Snyder Subject: Re: RFC: Avoid calling XXX_skip_prologue for assembly code References: <200204112330.g3BNUr827339@fred.ninemoons.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00456.txt.bz2 Fred, May I suggest the creation of a set/show command to allow this to be deactivated? set assembly-skip-prolog I don't mind if the default is off, I can put it in my .gdbinit file. But disallowing it in a hardwired way will punish anyone who followed the linkage conventions to be able to use backtrace. I strongly object to this patch unless accompanied by a set/show command. (But I am not the maintainer.) Regards, Fernando Fred Fish wrote: > > (Note: I'm revisiting an old patch submitted in Oct 2001) > > > Would you be willing to try gdb.asm/asm-source.exp against a D10V sim > > with this change? I'm pretty sure your change is going to break that > > test. If so, you could fix the failure by changing the test to set > > the breakpoint after the `enter' sequences. > > I just built a D10V toolchain with a recent gdb, and ran the full > testsuite with and without this change. There was no difference in > the testsuite results. All of the asm-source.exp tests passed both > with and without this patch installed. > > OK to check in this patch? > > -Fred -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9