From: Pedro Alves <pedro@palves.net>
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
Subject: Re: [PATCH 5/7] Add amd64_windows_gregset_reg_offset
Date: Fri, 3 Jul 2020 15:11:25 +0100 [thread overview]
Message-ID: <30c4f8a2-6b9b-3fd5-4bb2-7f315fe1bfb7@palves.net> (raw)
In-Reply-To: <20200701213225.14144-6-jon.turney@dronecode.org.uk>
On 7/1/20 10:32 PM, Jon Turney wrote:
> +/* This vector maps GDB's idea of a register's number into an offset into
> + the Windows API CONTEXT structure. */
> +static int amd64_windows_gregset_reg_offset[] =
> +{
> + 120, /* Rax */
> + 144, /* Rbx */
Super important nit (just kidding) -- array elements
should be indented by two spaces instead of just one.
next prev parent reply other threads:[~2020-07-03 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 21:32 [PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps Jon Turney
2020-07-01 21:32 ` [PATCH 1/7] Read tid from correct offset in win32pstatus NOTE_INFO_THREAD Jon Turney
2020-07-01 21:32 ` [PATCH 2/7] Don't apply size constraint to all win32pstatus ELF notes Jon Turney
2020-07-01 21:32 ` [PATCH 3/7] Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note Jon Turney
2020-07-06 20:12 ` Christian Biesinger
2020-07-01 21:32 ` [PATCH 4/7] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-07-02 23:59 ` Simon Marchi
2020-07-03 13:30 ` Jon Turney
2020-07-03 14:17 ` Simon Marchi
2020-07-06 18:46 ` Jon Turney
2020-07-01 21:32 ` [PATCH 5/7] Add amd64_windows_gregset_reg_offset Jon Turney
2020-07-03 14:11 ` Pedro Alves [this message]
2020-07-01 21:32 ` [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-07-02 23:53 ` Simon Marchi
2020-07-02 23:56 ` Simon Marchi
2020-07-03 13:14 ` Jon Turney
2020-07-01 21:32 ` [PATCH 7/7] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-07-06 20:13 ` Christian Biesinger
2020-07-08 15:50 ` Jon Turney
2020-07-08 16:11 ` Christian Biesinger
2020-07-12 12:58 ` Jon Turney
2020-07-02 21:17 ` [PATCH 0/7] Add gdb support for Cygwin x86_64 " Tom Tromey
2020-07-03 13:30 ` Jon Turney
2020-07-03 0:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c4f8a2-6b9b-3fd5-4bb2-7f315fe1bfb7@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox