From: Simon Marchi <simark@simark.ca>
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps
Date: Thu, 2 Jul 2020 20:00:17 -0400 [thread overview]
Message-ID: <40a6da6e-dbdc-e07d-449b-a05595ff94e0@simark.ca> (raw)
In-Reply-To: <20200701213225.14144-1-jon.turney@dronecode.org.uk>
On 2020-07-01 5:32 p.m., Jon Turney wrote:
> As far as I know, the only way to generate these "core dumps" is to use
> Cygwin's 'dumper' tool, which requires some fixes on x86_64 [1].
>
> [1] https://cygwin.com/pipermail/cygwin-patches/2020q3/010313.html
>
> Jon Turney (7):
> Read tid from correct offset in win32pstatus NOTE_INFO_THREAD
> Don't apply size constraint to all win32pstatus ELF notes.
> Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note
> Add sniffer for Cygwin x86_64 core dumps
> Add amd64_windows_gregset_reg_offset
> Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str
> Add handling for 64-bit module addresses in Cygwin core dumps
>
> bfd/ChangeLog | 20 ++++++++
> bfd/elf.c | 25 +++++----
> gdb/ChangeLog | 23 +++++++++
> gdb/amd64-windows-tdep.c | 100 ++++++++++++++++++++++++++++++++++++
> gdb/i386-windows-tdep.c | 100 +-----------------------------------
> gdb/windows-tdep.c | 108 +++++++++++++++++++++++++++++++++++++++
> gdb/windows-tdep.h | 8 +++
> 7 files changed, 276 insertions(+), 108 deletions(-)
>
> --
> 2.27.0
>
I've sent a few comments, but in general the GDB bits look fine to me. But
as Tom said, the bfd bits need to be approved by the binutils folks.
Simon
prev parent reply other threads:[~2020-07-03 0:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 21:32 Jon Turney
2020-07-01 21:32 ` [PATCH 1/7] Read tid from correct offset in win32pstatus NOTE_INFO_THREAD Jon Turney
2020-07-01 21:32 ` [PATCH 2/7] Don't apply size constraint to all win32pstatus ELF notes Jon Turney
2020-07-01 21:32 ` [PATCH 3/7] Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note Jon Turney
2020-07-06 20:12 ` Christian Biesinger
2020-07-01 21:32 ` [PATCH 4/7] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-07-02 23:59 ` Simon Marchi
2020-07-03 13:30 ` Jon Turney
2020-07-03 14:17 ` Simon Marchi
2020-07-06 18:46 ` Jon Turney
2020-07-01 21:32 ` [PATCH 5/7] Add amd64_windows_gregset_reg_offset Jon Turney
2020-07-03 14:11 ` Pedro Alves
2020-07-01 21:32 ` [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-07-02 23:53 ` Simon Marchi
2020-07-02 23:56 ` Simon Marchi
2020-07-03 13:14 ` Jon Turney
2020-07-01 21:32 ` [PATCH 7/7] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-07-06 20:13 ` Christian Biesinger
2020-07-08 15:50 ` Jon Turney
2020-07-08 16:11 ` Christian Biesinger
2020-07-12 12:58 ` Jon Turney
2020-07-02 21:17 ` [PATCH 0/7] Add gdb support for Cygwin x86_64 " Tom Tromey
2020-07-03 13:30 ` Jon Turney
2020-07-03 0:00 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a6da6e-dbdc-e07d-449b-a05595ff94e0@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox