From: Simon Marchi <simark@simark.ca>
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
Subject: Re: [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str
Date: Thu, 2 Jul 2020 19:53:45 -0400 [thread overview]
Message-ID: <de0c8bd9-dfb5-3618-19f6-8bb66115df4c@simark.ca> (raw)
In-Reply-To: <20200701213225.14144-7-jon.turney@dronecode.org.uk>
On 2020-07-01 5:32 p.m., Jon Turney wrote:
> Move windows_core_xfer_shared_libraries() and windows_core_pid_to_str()
> to windows-tdep, use in amd64-windows-tdep.c to handle Cygwin x86_64
> core dumps.
As a convention, the _initialize function is always at the bottom of the file,
so I'd put the new functions in windows-tdep.c just above it.
Were the functions copied as-is, or did you need to make changes to support 64-bits?
Simon
next prev parent reply other threads:[~2020-07-02 23:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 21:32 [PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps Jon Turney
2020-07-01 21:32 ` [PATCH 1/7] Read tid from correct offset in win32pstatus NOTE_INFO_THREAD Jon Turney
2020-07-01 21:32 ` [PATCH 2/7] Don't apply size constraint to all win32pstatus ELF notes Jon Turney
2020-07-01 21:32 ` [PATCH 3/7] Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note Jon Turney
2020-07-06 20:12 ` Christian Biesinger
2020-07-01 21:32 ` [PATCH 4/7] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-07-02 23:59 ` Simon Marchi
2020-07-03 13:30 ` Jon Turney
2020-07-03 14:17 ` Simon Marchi
2020-07-06 18:46 ` Jon Turney
2020-07-01 21:32 ` [PATCH 5/7] Add amd64_windows_gregset_reg_offset Jon Turney
2020-07-03 14:11 ` Pedro Alves
2020-07-01 21:32 ` [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-07-02 23:53 ` Simon Marchi [this message]
2020-07-02 23:56 ` Simon Marchi
2020-07-03 13:14 ` Jon Turney
2020-07-01 21:32 ` [PATCH 7/7] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-07-06 20:13 ` Christian Biesinger
2020-07-08 15:50 ` Jon Turney
2020-07-08 16:11 ` Christian Biesinger
2020-07-12 12:58 ` Jon Turney
2020-07-02 21:17 ` [PATCH 0/7] Add gdb support for Cygwin x86_64 " Tom Tromey
2020-07-03 13:30 ` Jon Turney
2020-07-03 0:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0c8bd9-dfb5-3618-19f6-8bb66115df4c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox