Re: [PATCH 7/7] Add handling for 64-bit module addresses in Cygwin core dumps

[Jon Turney <jon.turney@dronecode.org.uk>]

On 08/07/2020 17:11, Christian Biesinger via Gdb-patches wrote:
> On Wed, Jul 8, 2020 at 10:50 AM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>> On 06/07/2020 21:13, Christian Biesinger via Gdb-patches wrote:
>>> On Wed, Jul 1, 2020 at 4:34 PM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>>>> --- a/bfd/elf.c
>>>> +++ b/bfd/elf.c
>>>> @@ -10185,10 +10185,19 @@ elfcore_grok_win32pstatus (bfd *abfd, Elf_Internal_Note *note)
>>>>          break;
>>>>
>>>>        case 3 /* NOTE_INFO_MODULE */:
>>>> -      /* Make a ".module/xxxxxxxx" section.  */
>>>> +    case 4 /* NOTE_INFO_MODULE64 */:
>>>
>>> It really seems like these should be actual constants, which would
>>> also make it easier to understand...
>>
>> Absolutely.
>>
>> Before [1], this structure was defined by including Cygwin's
>> <sys/procfs.h> (so this code didn't work in cross-environments).
>>
>> I can't find a model of adding note structure definitions (the other
>> grok_note functions seem to rely on OS definitions), so I'm not sure
>> what kind of change you are asking me to make in this patch.
> 
> I was just suggesting adding a `static constexpr int
> NOTE_INFO_MODULE64 = 4` in some appropriate place, maybe at the top of
> this file.
> 
> Er, I guess this is bfd, so make it a #define.

I posted a revised patchset with that change (to the binutils list, 
where it belongs).