From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by sourceware.org (Postfix) with ESMTPS id 7CCB23844038 for ; Fri, 3 Jul 2020 14:11:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CCB23844038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f65.google.com with SMTP id r12so32785253wrj.13 for ; Fri, 03 Jul 2020 07:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ivb/ZDA4VrWcup8w1C5qHIygV4iv19WYFGTgnzPKHOQ=; b=Nko9l/AoH9UlHAhhlekDu6+FkukGH6xjf4xC3V5fX6cAoFZNHQtU5/dsWdEpDnhE+e dM8sQ3dHyrmP4KBgdMzU6lls63C6R+3BfC6lAeZDi8OG1ZbjNCACiTJO8V0/rWiUa2OI Z1VTwFy8Ni0Q+ALvbIVvK3wzUVKpjbQHrBaXiG8Wzb7TbcentNDChfUHjFY4DMuin/0T eMyGAQkEbE1qdnVQIC08u0su9dP+NoyEt3ww/uSt+4wBLH0iCY9Ny2Rtnf3EWHxthtnX Tbp2m15mjz8kDnbq+UH/9uDK2klUCpAnYMrHDoLydPoCuwDRF27F2kIRsIXXBPstr9xr FYbw== X-Gm-Message-State: AOAM5331y/2hkEAlzg8pmeLmPPb6RbZ7zF7yDx5qfkn7CqrMbfltMUUC NgRlU17vdcjUGEfJSdBP6iSh8Ef54nhgkw== X-Google-Smtp-Source: ABdhPJwxxnR0wJfHbXg9UQPJ1SYJjdO3ldh4TtmNtRbc/t8GCraNcve8Hzyv5JnqVztyZV2gkk+vgw== X-Received: by 2002:a5d:4682:: with SMTP id u2mr36304049wrq.407.1593785489174; Fri, 03 Jul 2020 07:11:29 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id d63sm14465413wmc.22.2020.07.03.07.11.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 07:11:28 -0700 (PDT) Subject: Re: [PATCH 5/7] Add amd64_windows_gregset_reg_offset To: Jon Turney , gdb-patches@sourceware.org References: <20200701213225.14144-1-jon.turney@dronecode.org.uk> <20200701213225.14144-6-jon.turney@dronecode.org.uk> From: Pedro Alves Message-ID: <30c4f8a2-6b9b-3fd5-4bb2-7f315fe1bfb7@palves.net> Date: Fri, 3 Jul 2020 15:11:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200701213225.14144-6-jon.turney@dronecode.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 14:11:31 -0000 On 7/1/20 10:32 PM, Jon Turney wrote: > +/* This vector maps GDB's idea of a register's number into an offset into > + the Windows API CONTEXT structure. */ > +static int amd64_windows_gregset_reg_offset[] = > +{ > + 120, /* Rax */ > + 144, /* Rbx */ Super important nit (just kidding) -- array elements should be indented by two spaces instead of just one.