Re: [PATCH v2 0/6] Move gdbsupport to top level

[Simon Marchi <simark@simark.ca>]

On 2020-01-17 8:35 a.m., Pedro Alves wrote:
>>> So the original solution of adding the gnulib dir to the include path
>>> isn't that bad, though I call it a hack.
>>
>> I would have to see it, but it sounds like the simplest solution.
> 
> It was the first patch I posted, here:
>  https://sourceware.org/ml/gdb-patches/2020-01/msg00419.html

Ok thanks, I did not follow this story from the beginning.

> But, gosh makes me realize there's an even simpler solution...
> Just rename support-config.h to config.h...  Do we need to call
> it something else for some reason?  I couldn't find one.

That's a good idea.

>>
>>>> The gdb-config.h above should be gdbserver-config.h.
>>> Here's v2.  WDYT?  Which of all the approaches discussed would
>>> you prefer?
>>
>> Probably the solution that involves the least files and indirections.  But
>> the one proposed in the latest patch is fine with me too.  It's set and
>> forget, once it builds again we won't think about it, at least until the
>> next time it breaks.
> 
> Note that we already kind of have the config.h indirections via common-defs.h,
> where we include the multiple config.h files.  This just moves those
> indirections to the file actually named config.h.
> 
>> The buildbot is struggling with this (sending many breakage emails), so I
>> think you should choose one and push it.  Then we can cancel all the builds
>> on the master branch until that commit.
> 
> Anyway, here's the simpler patch...    Let's call it approach #3.
> 
> Approach #1 - add -Ignulib
> Approach #2 - add wrapper config.h files in the source dirs
> Approach #3 - rename support-config.h -> config.h

I'd say let's go for #3, since that's how gdb and gdbserver already work,
it's been working well for years, so it's proven already.

Simon