From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level
Date: Tue, 14 Jan 2020 23:25:00 -0000 [thread overview]
Message-ID: <877e1t1ved.fsf@tromey.com> (raw)
In-Reply-To: <11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca> (Simon Marchi's message of "Sat, 11 Jan 2020 21:19:08 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> The indentation in common.m4 looks off, starting with:
Simon> AC_CACHE_CHECK([for sigsetjmp], gdb_cv_func_sigsetjmp
Simon> Starting from this line until the end, I think it should be indented by
Simon> two columns. It's already wrong today, but what you added also has wrong
Simon> indentation, making it hard to understand that it's all under `GDB_AC_COMMON`.
Simon> Could you fix that? I don't really mind if it's a patch before or after this
Simon> series.
I will send and check in a patch for that shortly.
Simon> I see that GDB_AC_PTRACE is called in all three configure.ac files. Should it
Simon> be put in GDB_AC_COMMON?
We don't have a good way to include ptrace.m4 from common.m4. Maybe the
call could be moved there but the user still has to know to include
ptrace.m4 somewhere.
Tom
next prev parent reply other threads:[~2020-01-14 23:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 0:58 Tom Tromey
2020-01-09 0:58 ` [PATCH v2 6/6] Don't link gdb twice against libiberty Tom Tromey
2020-01-09 0:58 ` [PATCH v2 5/6] Add gdbsupport check-defines script Tom Tromey
2020-01-09 0:58 ` [PATCH v2 1/6] Consolidate definition of USE_WIN32API Tom Tromey
2020-01-09 0:58 ` [PATCH v2 4/6] Remove use of <config.h> from gdb/nat/ Tom Tromey
2020-01-11 16:58 ` [PATCH v2 0/6] Move gdbsupport to top level Tom Tromey
2020-01-12 2:48 ` Simon Marchi
2020-01-14 23:25 ` Tom Tromey [this message]
2020-01-15 0:36 ` Tom Tromey
2020-01-15 21:27 ` Christian Biesinger via gdb-patches
2020-01-17 18:02 ` Tom Tromey
2020-01-15 14:30 ` Pedro Alves
[not found] ` <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com>
2020-01-15 16:07 ` Pedro Alves
[not found] ` <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com>
2020-01-15 21:46 ` Pedro Alves
2020-01-15 22:12 ` Pedro Alves
2020-01-16 0:48 ` Pedro Alves
2020-01-16 2:57 ` Christian Biesinger via gdb-patches
2020-01-16 17:22 ` Pedro Alves
2020-01-16 18:01 ` Christian Biesinger via gdb-patches
2020-01-16 18:28 ` Pedro Alves
2020-01-16 19:21 ` Christian Biesinger via gdb-patches
2020-01-16 9:02 ` Simon Marchi
2020-01-16 15:24 ` Pedro Alves
2020-01-17 12:20 ` Simon Marchi
2020-01-17 13:37 ` Pedro Alves
2020-01-17 14:40 ` Simon Marchi
2020-01-17 15:32 ` Pedro Alves
2020-01-17 18:13 ` Tom Tromey
2020-01-16 4:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e1t1ved.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox