From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level
Date: Sun, 12 Jan 2020 02:48:00 -0000 [thread overview]
Message-ID: <11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca> (raw)
In-Reply-To: <878smeexqf.fsf@tromey.com>
On 2020-01-11 11:58 a.m., Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> Here is an update of the series to move gdbsupport to the top level.
> Tom> This is one step in the bigger projecct to move gdbserver to top
> Tom> level.
>
> I see that patches #2 and #3 did not come through.
> I think they ran into the size limit.
>
> Here is patch 2. I'll send patch 3 separately.
> Using "git show" makes patch 2 smaller, but I'm also going to edit out
> the generated files from both patches.
The indentation in common.m4 looks off, starting with:
AC_CACHE_CHECK([for sigsetjmp], gdb_cv_func_sigsetjmp
Starting from this line until the end, I think it should be indented by
two columns. It's already wrong today, but what you added also has wrong
indentation, making it hard to understand that it's all under `GDB_AC_COMMON`.
Could you fix that? I don't really mind if it's a patch before or after this
series.
I see that GDB_AC_PTRACE is called in all three configure.ac files. Should it
be put in GDB_AC_COMMON?
Other than that, the series LGTM.
Simon
next prev parent reply other threads:[~2020-01-12 2:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 0:58 Tom Tromey
2020-01-09 0:58 ` [PATCH v2 6/6] Don't link gdb twice against libiberty Tom Tromey
2020-01-09 0:58 ` [PATCH v2 4/6] Remove use of <config.h> from gdb/nat/ Tom Tromey
2020-01-09 0:58 ` [PATCH v2 1/6] Consolidate definition of USE_WIN32API Tom Tromey
2020-01-09 0:58 ` [PATCH v2 5/6] Add gdbsupport check-defines script Tom Tromey
2020-01-11 16:58 ` [PATCH v2 0/6] Move gdbsupport to top level Tom Tromey
2020-01-12 2:48 ` Simon Marchi [this message]
2020-01-14 23:25 ` Tom Tromey
2020-01-15 0:36 ` Tom Tromey
2020-01-15 21:27 ` Christian Biesinger via gdb-patches
2020-01-17 18:02 ` Tom Tromey
2020-01-15 14:30 ` Pedro Alves
[not found] ` <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com>
2020-01-15 16:07 ` Pedro Alves
[not found] ` <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com>
2020-01-15 21:46 ` Pedro Alves
2020-01-15 22:12 ` Pedro Alves
2020-01-16 0:48 ` Pedro Alves
2020-01-16 2:57 ` Christian Biesinger via gdb-patches
2020-01-16 17:22 ` Pedro Alves
2020-01-16 18:01 ` Christian Biesinger via gdb-patches
2020-01-16 18:28 ` Pedro Alves
2020-01-16 19:21 ` Christian Biesinger via gdb-patches
2020-01-16 9:02 ` Simon Marchi
2020-01-16 15:24 ` Pedro Alves
2020-01-17 12:20 ` Simon Marchi
2020-01-17 13:37 ` Pedro Alves
2020-01-17 14:40 ` Simon Marchi
2020-01-17 15:32 ` Pedro Alves
2020-01-17 18:13 ` Tom Tromey
2020-01-16 4:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox