From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112852 invoked by alias); 12 Jan 2020 02:19:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112160 invoked by uid 89); 12 Jan 2020 02:19:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=am X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 12 Jan 2020 02:19:10 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C36BA1E4C2; Sat, 11 Jan 2020 21:19:08 -0500 (EST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> <878smeexqf.fsf@tromey.com> From: Simon Marchi Message-ID: <11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca> Date: Sun, 12 Jan 2020 02:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <878smeexqf.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00300.txt.bz2 On 2020-01-11 11:58 a.m., Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> Here is an update of the series to move gdbsupport to the top level. > Tom> This is one step in the bigger projecct to move gdbserver to top > Tom> level. > > I see that patches #2 and #3 did not come through. > I think they ran into the size limit. > > Here is patch 2. I'll send patch 3 separately. > Using "git show" makes patch 2 smaller, but I'm also going to edit out > the generated files from both patches. The indentation in common.m4 looks off, starting with: AC_CACHE_CHECK([for sigsetjmp], gdb_cv_func_sigsetjmp Starting from this line until the end, I think it should be indented by two columns. It's already wrong today, but what you added also has wrong indentation, making it hard to understand that it's all under `GDB_AC_COMMON`. Could you fix that? I don't really mind if it's a patch before or after this series. I see that GDB_AC_PTRACE is called in all three configure.ac files. Should it be put in GDB_AC_COMMON? Other than that, the series LGTM. Simon