From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level
Date: Fri, 17 Jan 2020 18:13:00 -0000 [thread overview]
Message-ID: <871rryhs0x.fsf@tromey.com> (raw)
In-Reply-To: <6b0b7f90-f526-73a9-3de8-aea958688d15@redhat.com> (Pedro Alves's message of "Fri, 17 Jan 2020 15:17:52 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>>> Approach #3 - rename support-config.h -> config.h
>>
>> I'd say let's go for #3, since that's how gdb and gdbserver already work,
>> it's been working well for years, so it's proven already.
Pedro> I've merged #3 now. We discussed adding a comment to
Pedro> gdbsupport/Makefile.am about the order of include paths, but it
Pedro> turns out that the -I. is added by automake by default
Pedro> (DEFAULT_INCLUDES), not explicitly set. gdb and gdbserver's
Pedro> Makefile.in have comments about it already. So I applied the
Pedro> patch as it was.
Thank you for doing this, and please accept my apologies for landing
that patch and then being out of commission for the following days.
Tom
next prev parent reply other threads:[~2020-01-17 18:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 0:58 Tom Tromey
2020-01-09 0:58 ` [PATCH v2 4/6] Remove use of <config.h> from gdb/nat/ Tom Tromey
2020-01-09 0:58 ` [PATCH v2 1/6] Consolidate definition of USE_WIN32API Tom Tromey
2020-01-09 0:58 ` [PATCH v2 5/6] Add gdbsupport check-defines script Tom Tromey
2020-01-09 0:58 ` [PATCH v2 6/6] Don't link gdb twice against libiberty Tom Tromey
2020-01-11 16:58 ` [PATCH v2 0/6] Move gdbsupport to top level Tom Tromey
2020-01-12 2:48 ` Simon Marchi
2020-01-14 23:25 ` Tom Tromey
2020-01-15 0:36 ` Tom Tromey
2020-01-15 21:27 ` Christian Biesinger via gdb-patches
2020-01-17 18:02 ` Tom Tromey
2020-01-15 14:30 ` Pedro Alves
[not found] ` <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com>
2020-01-15 16:07 ` Pedro Alves
[not found] ` <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com>
2020-01-15 21:46 ` Pedro Alves
2020-01-15 22:12 ` Pedro Alves
2020-01-16 0:48 ` Pedro Alves
2020-01-16 2:57 ` Christian Biesinger via gdb-patches
2020-01-16 17:22 ` Pedro Alves
2020-01-16 18:01 ` Christian Biesinger via gdb-patches
2020-01-16 18:28 ` Pedro Alves
2020-01-16 19:21 ` Christian Biesinger via gdb-patches
2020-01-16 9:02 ` Simon Marchi
2020-01-16 15:24 ` Pedro Alves
2020-01-17 12:20 ` Simon Marchi
2020-01-17 13:37 ` Pedro Alves
2020-01-17 14:40 ` Simon Marchi
2020-01-17 15:32 ` Pedro Alves
2020-01-17 18:13 ` Tom Tromey [this message]
2020-01-16 4:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rryhs0x.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox