From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106955 invoked by alias); 17 Jan 2020 14:10:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106942 invoked by uid 89); 17 Jan 2020 14:10:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=emails X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 14:10:43 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D4F831E47D; Fri, 17 Jan 2020 09:10:40 -0500 (EST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> <437c1b86-0aa8-57b9-53e2-f21567e2bb14@redhat.com> <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com> <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> <053b43db-381c-a72d-ea5d-9bcb74a8440c@simark.ca> <78d5599b-9773-954f-ea06-86f65a1c6842@redhat.com> From: Simon Marchi Message-ID: <2cb89dd1-f029-d495-4823-72ae2d5253d2@simark.ca> Date: Fri, 17 Jan 2020 14:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00528.txt.bz2 On 2020-01-17 8:35 a.m., Pedro Alves wrote: >>> So the original solution of adding the gnulib dir to the include path >>> isn't that bad, though I call it a hack. >> >> I would have to see it, but it sounds like the simplest solution. > > It was the first patch I posted, here: > https://sourceware.org/ml/gdb-patches/2020-01/msg00419.html Ok thanks, I did not follow this story from the beginning. > But, gosh makes me realize there's an even simpler solution... > Just rename support-config.h to config.h... Do we need to call > it something else for some reason? I couldn't find one. That's a good idea. >> >>>> The gdb-config.h above should be gdbserver-config.h. >>> Here's v2. WDYT? Which of all the approaches discussed would >>> you prefer? >> >> Probably the solution that involves the least files and indirections. But >> the one proposed in the latest patch is fine with me too. It's set and >> forget, once it builds again we won't think about it, at least until the >> next time it breaks. > > Note that we already kind of have the config.h indirections via common-defs.h, > where we include the multiple config.h files. This just moves those > indirections to the file actually named config.h. > >> The buildbot is struggling with this (sending many breakage emails), so I >> think you should choose one and push it. Then we can cancel all the builds >> on the master branch until that commit. > > Anyway, here's the simpler patch... Let's call it approach #3. > > Approach #1 - add -Ignulib > Approach #2 - add wrapper config.h files in the source dirs > Approach #3 - rename support-config.h -> config.h I'd say let's go for #3, since that's how gdb and gdbserver already work, it's been working well for years, so it's proven already. Simon