Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.

[Peter Bergner <bergner@vnet.ibm.com>]

On 11/3/16 6:01 AM, Pedro Alves wrote:
> On 10/28/2016 03:53 PM, Peter Bergner wrote:
> BTW, I'm also not sure about saying "default" in "show disassembler-options".
> I don't think "set disassembler-options default" would work?
> Do we still need that given the option is no longer described in
> terms of cpus?

Uli and I discussed this here:

   https://sourceware.org/ml/gdb-patches/2016-10/msg00184.html
   https://sourceware.org/ml/gdb-patches/2016-10/msg00188.html

Uli didn't like (at least the way the code was written in the earlier
patch) how I was trying to initialize the disassembler_options
to a default.  He thought that just leaving disassembler_options NULL
and letting the arch choose its default was best.  That's when I added
the code to emit "default" whenever disassembler_options is NULL.



> Related, "set disassembler-options" should work to clear options.
> I couldn't tell whether it works from a quick skim over your
> latest patch.

As part of my last patch:

   https://sourceware.org/ml/gdb-patches/2016-11/msg00023.html

...is said:

 > Secondly, I wanted a way for the user to go back to the default
 > (ie, NULL) disassembler option.  I could only do that first I
 > removed white space.  I added the comma cleanup since it was
 > easy.

So yes, we can go back to the NULL default.

Peter