From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: bergner@vnet.ibm.com (Peter Bergner)
Cc: palves@redhat.com (Pedro Alves), amodra@gmail.com (Alan Modra),
gdb-patches@sourceware.org,
binutils@sourceware.org (binutils)
Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.
Date: Wed, 12 Oct 2016 08:08:00 -0000 [thread overview]
Message-ID: <20161012080801.C867010FDC3@oc8523832656.ibm.com> (raw)
In-Reply-To: <25537872-c66e-f92d-aa28-cedb9df0f1a6@vnet.ibm.com> from "Peter Bergner" at Oct 10, 2016 06:28:14 PM
Peter Bergner wrote:
> On 10/7/16 2:21 PM, Ulrich Weigand wrote:
> > There's a second use of disassemble_init_for_target, which probably needs
> > the same treatment. In fact, maybe the nicest way would be to call the
> > callback "gdbarch_disassemble_init_for_target", with a default of simply
> > disassemble_init_for_target, but which targets can override to do extra
> > stuff before (or after) calling disassemble_init_for_target in there.
> > GDB common code would then just call gdbarch_disassemble_init_for_target
> > everywhere it currently calls disassemble_init_for_target.
>
> Ok, I think this resolves all of your last suggestions. Is this better?
>
> Peter
>
>
>
> include/
> * dis-asm.h (ppc_verify_disassembler_options): New prototype.
>
> opcodes/
> * ppc-dis.c (parse_ppc_dis_option): New function.
> (ppc_verify_disassembler_options): Likewise.
> (powerpc_init_dialect): Use parse_ppc_dis_option().
>
> gdb/
> * gdbarch.sh (gdbarch_disassemble_init_for_target): New function.
> * gdbarch.c: Regenerate.
> * gdbarch.h: Likewise.
> * disasm.c (gdb_disassemble_info): Use it.
> (gdb_buffered_insn_length_init_dis): Likewise.
> * rs6000-tdep.c: (gdb_disassembler_cpu): New static declaration.
> (prospective_cpu): Likewise.
> (gdb_disassemble_init_for_ppc): New function.
> (set_disassembler_cpu): Likewise.
> (show_disassembler_cpu): Likewise.
> (rs6000_gdbarch_init): Setup callback for gdb_disassemble_init_for_ppc.
> (_initialize_rs6000_tdep): Setup callbacks for set_disassembler_cpu()
> and show_disassembler_cpu().
> * arch-utils.c: Include "dis-asm.h".
> (default_disassemble_init_for_target): New function.
> * arch-utils.h (default_disassemble_init_for_target): New Prototype.
Yes, for a PowerPC-only solution this patch looks fine to me. Thanks!
However, we should resolve the separate discussion with Pedro about
maybe getting a fully platform-independent solution first ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-10-12 8:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 2:14 Peter Bergner
2016-09-30 17:55 ` Ulrich Weigand
2016-10-03 20:25 ` Peter Bergner
2016-10-03 22:25 ` Alan Modra
2016-10-06 3:00 ` Peter Bergner
2016-10-06 4:44 ` Alan Modra
2016-10-06 9:52 ` Pedro Alves
2016-10-06 19:26 ` Peter Bergner
2016-10-07 19:21 ` Ulrich Weigand
2016-10-07 21:01 ` Peter Bergner
2016-10-08 14:39 ` Ulrich Weigand
2016-10-10 23:28 ` Peter Bergner
2016-10-12 8:08 ` Ulrich Weigand [this message]
2016-10-12 10:46 ` Pedro Alves
2016-10-11 0:09 ` Pedro Alves
2016-10-11 18:49 ` Peter Bergner
2016-10-12 8:25 ` Ulrich Weigand
2016-10-27 0:04 ` Peter Bergner
2016-10-27 9:40 ` Pedro Alves
2016-10-28 13:47 ` Peter Bergner
2016-10-28 14:10 ` Pedro Alves
2016-10-28 14:24 ` Peter Bergner
2016-10-28 14:30 ` Pedro Alves
2016-10-28 14:53 ` Peter Bergner
2016-11-03 11:01 ` Pedro Alves
2016-11-03 15:02 ` Peter Bergner
2016-11-03 15:06 ` Peter Bergner
2016-11-03 16:41 ` Ulrich Weigand
2016-11-03 16:49 ` Peter Bergner
2016-10-28 12:32 ` Ulrich Weigand
2016-10-28 13:45 ` Peter Bergner
2016-10-28 14:15 ` Ulrich Weigand
2016-10-28 15:02 ` Peter Bergner
2016-10-28 18:47 ` Ulrich Weigand
2016-11-02 23:28 ` Peter Bergner
2016-10-12 19:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012080801.C867010FDC3@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=amodra@gmail.com \
--cc=bergner@vnet.ibm.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox