Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
	gdb-patches@sourceware.org,	binutils <binutils@sourceware.org>
Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.
Date: Mon, 03 Oct 2016 22:25:00 -0000	[thread overview]
Message-ID: <20161003222527.GO4877@bubble.grove.modra.org> (raw)
In-Reply-To: <aff72146-3dc5-50ec-3382-fc7a6c917cb1@vnet.ibm.com>

On Mon, Oct 03, 2016 at 03:25:15PM -0500, Peter Bergner wrote:
> On 9/30/16 11:19 AM, Ulrich Weigand wrote:
> > The implementation in the patch does appear to be a bit ad-hoc, however :-)
> > Why would we want to pass that information via a new global variable, if
> > there is already an element "disassembler_options" in the struct
> > disassemble_info that GDB passes to bfd?  See e.g. i386_print_insn.
> 
> Yes, I saw that code.  The problem is that same solution won't work for
> us, since print_insn_*() doesn't look at info->disassembler_options
> at all.

Somewhere in gdb you must be calling disassemble_init_for_target.
Why can't you call that again after setting the cpu (in struct
disassemble_info disassembler_options)?

-- 
Alan Modra
Australia Development Lab, IBM


  reply	other threads:[~2016-10-03 22:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30  2:14 Peter Bergner
2016-09-30 17:55 ` Ulrich Weigand
2016-10-03 20:25   ` Peter Bergner
2016-10-03 22:25     ` Alan Modra [this message]
2016-10-06  3:00       ` Peter Bergner
2016-10-06  4:44         ` Alan Modra
2016-10-06  9:52         ` Pedro Alves
2016-10-06 19:26           ` Peter Bergner
2016-10-07 19:21             ` Ulrich Weigand
2016-10-07 21:01               ` Peter Bergner
2016-10-08 14:39                 ` Ulrich Weigand
2016-10-10 23:28               ` Peter Bergner
2016-10-12  8:08                 ` Ulrich Weigand
2016-10-12 10:46                   ` Pedro Alves
2016-10-11  0:09             ` Pedro Alves
2016-10-11 18:49               ` Peter Bergner
2016-10-12  8:25                 ` Ulrich Weigand
2016-10-27  0:04                   ` Peter Bergner
2016-10-27  9:40                     ` Pedro Alves
2016-10-28 13:47                       ` Peter Bergner
2016-10-28 14:10                         ` Pedro Alves
2016-10-28 14:24                           ` Peter Bergner
2016-10-28 14:30                             ` Pedro Alves
2016-10-28 14:53                               ` Peter Bergner
2016-11-03 11:01                                 ` Pedro Alves
2016-11-03 15:02                                   ` Peter Bergner
2016-11-03 15:06                                     ` Peter Bergner
2016-11-03 16:41                                     ` Ulrich Weigand
2016-11-03 16:49                                       ` Peter Bergner
2016-10-28 12:32                     ` Ulrich Weigand
2016-10-28 13:45                       ` Peter Bergner
2016-10-28 14:15                         ` Ulrich Weigand
2016-10-28 15:02                           ` Peter Bergner
2016-10-28 18:47                             ` Ulrich Weigand
2016-11-02 23:28                               ` Peter Bergner
2016-10-12 19:35                 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003222527.GO4877@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=bergner@vnet.ibm.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox