From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72673 invoked by alias); 3 Nov 2016 15:02:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72649 invoked by uid 89); 3 Nov 2016 15:02:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 15:02:28 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA3EwSIF033900 for ; Thu, 3 Nov 2016 11:02:27 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 26g3g9tj6b-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 03 Nov 2016 11:02:27 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Nov 2016 09:02:25 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 3 Nov 2016 09:02:22 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 7169A19D8051; Thu, 3 Nov 2016 09:01:45 -0600 (MDT) Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA3F2L9C11206936; Thu, 3 Nov 2016 08:02:21 -0700 Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 581C26A051; Thu, 3 Nov 2016 09:02:21 -0600 (MDT) Received: from otta.local (unknown [9.80.208.39]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id 866A26A067; Thu, 3 Nov 2016 09:02:20 -0600 (MDT) Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER. To: Pedro Alves , Ulrich Weigand References: <20161012082525.3250910FDC3@oc8523832656.ibm.com> <88940498-822b-b192-b983-d8571a81ad87@redhat.com> <2c62687d-f013-5af8-96ae-d7f56d28c218@redhat.com> <4f8959a7-33b9-385c-3c63-2d5b26286579@vnet.ibm.com> <3b814d5e-f716-f1c7-1530-684901b28e30@redhat.com> <88312c99-f1bb-c3d9-8e65-8ab64f086f42@vnet.ibm.com> <8733fac4-9e5d-43de-75a6-0f191c4000e7@redhat.com> Cc: Alan Modra , gdb-patches@sourceware.org, binutils From: Peter Bergner Date: Thu, 03 Nov 2016 15:02:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8733fac4-9e5d-43de-75a6-0f191c4000e7@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110315-0004-0000-0000-000010C219CB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006026; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000189; SDB=6.00776259; UDB=6.00373383; IPR=6.00553418; BA=6.00004855; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013201; XFM=3.00000011; UTC=2016-11-03 15:02:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110315-0005-0000-0000-00007A44D420 Message-Id: <25f99efc-6ff0-3908-dbab-fe3792be770f@vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-03_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611030277 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00054.txt.bz2 On 11/3/16 6:01 AM, Pedro Alves wrote: > On 10/28/2016 03:53 PM, Peter Bergner wrote: > BTW, I'm also not sure about saying "default" in "show disassembler-options". > I don't think "set disassembler-options default" would work? > Do we still need that given the option is no longer described in > terms of cpus? Uli and I discussed this here: https://sourceware.org/ml/gdb-patches/2016-10/msg00184.html https://sourceware.org/ml/gdb-patches/2016-10/msg00188.html Uli didn't like (at least the way the code was written in the earlier patch) how I was trying to initialize the disassembler_options to a default. He thought that just leaving disassembler_options NULL and letting the arch choose its default was best. That's when I added the code to emit "default" whenever disassembler_options is NULL. > Related, "set disassembler-options" should work to clear options. > I couldn't tell whether it works from a quick skim over your > latest patch. As part of my last patch: https://sourceware.org/ml/gdb-patches/2016-11/msg00023.html ...is said: > Secondly, I wanted a way for the user to go back to the default > (ie, NULL) disassembler option. I could only do that first I > removed white space. I added the comma cleanup since it was > easy. So yes, we can go back to the NULL default. Peter