From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 01/15] Add back declarations for _initialize functions
Date: Thu, 09 Jan 2020 22:50:00 -0000 [thread overview]
Message-ID: <23b12f35-00ab-cf51-7aee-994652a688d1@efficios.com> (raw)
In-Reply-To: <87a76wxntd.fsf@tromey.com>
On 2020-01-09 5:33 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> And among those, the functions used both in the in-process agent
> Simon> and in gdbserver itself are problematic, because they should be exported when
> Simon> built for the IPA, but static when built for gdbserver. So I gave up on it
> Simon> for the moment. This patch (01/15) would only be relevant if the rest goes in
> Simon> too, but I note your comment about clang.
>
> Is it on a branch somewhere? Maybe it wouldn't be too hard to finish up.
>
> Tom
>
I have just uploaded it to the "missing-declarations" branch on my github:
https://github.com/simark/binutils-gdb/tree/missing-declarations
I have updated the patches slightly to account for the new unittests. So if you
try to build, you'll stumble directly on the build error that made me give up:
/home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c: In function ‘void gdb_agent_stop_tracing()’:
/home/smarchi/src/binutils-gdb/gdb/gdbserver/../gdbsupport/agent.h:29:36: error: no previous declaration for ‘void gdb_agent_stop_tracing()’ [-Werror=missing-declarations]
#define IPA_SYM_EXPORTED_NAME(SYM) gdb_agent_ ## SYM
^
/home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c:114:23: note: in expansion of macro ‘IPA_SYM_EXPORTED_NAME’
# define stop_tracing IPA_SYM_EXPORTED_NAME (stop_tracing)
^~~~~~~~~~~~~~~~~~~~~
/home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c:374:1: note: in expansion of macro ‘stop_tracing’
stop_tracing (void)
^~~~~~~~~~~~
Simon
next prev parent reply other threads:[~2020-01-09 22:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 5:27 [PATCH 00/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 5:27 ` [PATCH 06/15] Remove dict_empty/mdict_empty Simon Marchi
2019-11-25 5:27 ` [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Simon Marchi
2019-11-25 5:27 ` [PATCH 04/15] Remove unused function set_gdb_completion_word_break_characters Simon Marchi
2019-11-25 5:27 ` [PATCH 12/15] Make functions static in unittests Simon Marchi
2019-11-25 5:27 ` [PATCH 01/15] Add back declarations for _initialize functions Simon Marchi
2020-01-09 18:46 ` John Baldwin
2020-01-09 22:23 ` Simon Marchi
2020-01-09 22:33 ` Tom Tromey
2020-01-09 22:50 ` Simon Marchi [this message]
2020-01-10 18:43 ` Tom Tromey
2020-01-10 21:46 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 11/15] Remove declaration of tui_set_var_cmd, make definition static Simon Marchi
2019-11-25 5:27 ` [PATCH 03/15] Add missing includes in dwarf-index-write.c and mi/mi-interp.c Simon Marchi
2019-11-25 5:27 ` [PATCH 15/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 22:06 ` Tom Tromey
2019-11-25 22:11 ` Simon Marchi
2019-11-26 14:12 ` Tom Tromey
2019-11-26 19:48 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 05/15] Make a bunch of functions static Simon Marchi
2019-11-25 5:27 ` [PATCH 07/15] Remove unused overload of exit_inferior_silent Simon Marchi
2019-11-25 5:27 ` [PATCH 13/15] Remove simulator_command declaration, make static Simon Marchi
2019-11-25 5:33 ` [PATCH 09/15] Add declaration to python init func Simon Marchi
2019-11-25 5:33 ` [PATCH 10/15] Remove unused rbreak_command_wrapper and other declarations Simon Marchi
2019-11-25 5:33 ` [PATCH 08/15] Remove info_terminal_command declaration, make definition static Simon Marchi
2019-11-25 5:33 ` [PATCH 14/15] Fix declaration of sparc_xfer_wcookie Simon Marchi
2019-11-25 22:08 ` [PATCH 00/15] Enable -Wmissing-declarations diagnostic Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23b12f35-00ab-cf51-7aee-994652a688d1@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox