Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 08/15] Remove info_terminal_command declaration, make definition static
Date: Mon, 25 Nov 2019 05:33:00 -0000	[thread overview]
Message-ID: <20191125052655.22696-9-simon.marchi@efficios.com> (raw)
In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com>

The info_terminal_command declaration in inflow.h does not match the
current definition.  It is not needed anyway, as info_terminal_command
is only used locally, so remove it and make the definition static.

gdb/ChangeLog:

	* inferior.h (info_terminal_command): Remove declaration.
	* inflow.c (info_terminal_command): Make static.

Change-Id: I22c3fcc44244e3cf877b5e27eff189af11c39503
---
 gdb/inferior.h | 2 --
 gdb/inflow.c   | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/gdb/inferior.h b/gdb/inferior.h
index 43f0417e6296..3bd9e8c3d747 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -159,8 +159,6 @@ extern void default_print_float_info (struct gdbarch *gdbarch,
 
 extern void child_terminal_info (struct target_ops *self, const char *, int);
 
-extern void info_terminal_command (char *, int);
-
 extern void child_terminal_ours (struct target_ops *self);
 
 extern void child_terminal_ours_for_output (struct target_ops *self);
diff --git a/gdb/inflow.c b/gdb/inflow.c
index 9b78301f254f..be9943e8a036 100644
--- a/gdb/inflow.c
+++ b/gdb/inflow.c
@@ -673,7 +673,7 @@ swap_terminal_info (inferior *a, inferior *b)
   std::swap (a->terminal_state, b->terminal_state);
 }
 
-void
+static void
 info_terminal_command (const char *arg, int from_tty)
 {
   target_terminal::info (arg, from_tty);
-- 
2.24.0


  parent reply	other threads:[~2019-11-25  5:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  5:27 [PATCH 00/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25  5:27 ` [PATCH 11/15] Remove declaration of tui_set_var_cmd, make definition static Simon Marchi
2019-11-25  5:27 ` [PATCH 15/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 22:06   ` Tom Tromey
2019-11-25 22:11     ` Simon Marchi
2019-11-26 14:12       ` Tom Tromey
2019-11-26 19:48         ` Simon Marchi
2019-11-25  5:27 ` [PATCH 03/15] Add missing includes in dwarf-index-write.c and mi/mi-interp.c Simon Marchi
2019-11-25  5:27 ` [PATCH 05/15] Make a bunch of functions static Simon Marchi
2019-11-25  5:27 ` [PATCH 06/15] Remove dict_empty/mdict_empty Simon Marchi
2019-11-25  5:27 ` [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Simon Marchi
2019-11-25  5:27 ` [PATCH 04/15] Remove unused function set_gdb_completion_word_break_characters Simon Marchi
2019-11-25  5:27 ` [PATCH 12/15] Make functions static in unittests Simon Marchi
2019-11-25  5:27 ` [PATCH 01/15] Add back declarations for _initialize functions Simon Marchi
2020-01-09 18:46   ` John Baldwin
2020-01-09 22:23     ` Simon Marchi
2020-01-09 22:33       ` Tom Tromey
2020-01-09 22:50         ` Simon Marchi
2020-01-10 18:43           ` Tom Tromey
2020-01-10 21:46             ` Simon Marchi
2019-11-25  5:27 ` [PATCH 13/15] Remove simulator_command declaration, make static Simon Marchi
2019-11-25  5:27 ` [PATCH 07/15] Remove unused overload of exit_inferior_silent Simon Marchi
2019-11-25  5:33 ` [PATCH 09/15] Add declaration to python init func Simon Marchi
2019-11-25  5:33 ` [PATCH 10/15] Remove unused rbreak_command_wrapper and other declarations Simon Marchi
2019-11-25  5:33 ` [PATCH 14/15] Fix declaration of sparc_xfer_wcookie Simon Marchi
2019-11-25  5:33 ` Simon Marchi [this message]
2019-11-25 22:08 ` [PATCH 00/15] Enable -Wmissing-declarations diagnostic Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125052655.22696-9-simon.marchi@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox