From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 03/15] Add missing includes in dwarf-index-write.c and mi/mi-interp.c
Date: Mon, 25 Nov 2019 05:27:00 -0000 [thread overview]
Message-ID: <20191125052655.22696-4-simon.marchi@efficios.com> (raw)
In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com>
The following errors show that these files are missing the include of
their matching header, add them.
CXX dwarf-index-write.o
/home/smarchi/src/binutils-gdb/gdb/dwarf-index-write.c: In function ‘void write_psymtabs_to_index(dwarf2_per_objfile*, const char*, const char*, const char*, dw_index_kind)’:
/home/smarchi/src/binutils-gdb/gdb/dwarf-index-write.c:1670:1: error: no previous declaration for ‘void write_psymtabs_to_index(dwarf2_per_objfile*, const char*, const char*, const char*, dw_index_kind)’ [-Werror=missing-declarations]
write_psymtabs_to_index (struct dwarf2_per_objfile *dwarf2_per_objfile,
^~~~~~~~~~~~~~~~~~~~~~~
CXX mi/mi-interp.o
/home/smarchi/src/binutils-gdb/gdb/mi/mi-interp.c: In function ‘void mi_output_solib_attribs(ui_out*, so_list*)’:
/home/smarchi/src/binutils-gdb/gdb/mi/mi-interp.c:1030:1: error: no previous declaration for ‘void mi_output_solib_attribs(ui_out*, so_list*)’ [-Werror=missing-declarations]
mi_output_solib_attribs (ui_out *uiout, struct so_list *solib)
^~~~~~~~~~~~~~~~~~~~~~~
gdb/ChangeLog:
* dwarf-index-write.c: Include dwarf-index-write.h.
* mi/mi-interp.c: Include mi/mi-interp.h.
Change-Id: I0103b8669e16e0fcaa476f8c5e96f49608157745
---
gdb/dwarf-index-write.c | 2 ++
gdb/mi/mi-interp.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/gdb/dwarf-index-write.c b/gdb/dwarf-index-write.c
index 1e101182e577..b0c2bc885a57 100644
--- a/gdb/dwarf-index-write.c
+++ b/gdb/dwarf-index-write.c
@@ -19,6 +19,8 @@
#include "defs.h"
+#include "dwarf-index-write.h"
+
#include "addrmap.h"
#include "cli/cli-decode.h"
#include "gdbsupport/byte-vector.h"
diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
index 4979eb91b5ec..2358280ad115 100644
--- a/gdb/mi/mi-interp.c
+++ b/gdb/mi/mi-interp.c
@@ -18,6 +18,9 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
+
+#include "mi-interp.h"
+
#include "interps.h"
#include "event-top.h"
#include "event-loop.h"
--
2.24.0
next prev parent reply other threads:[~2019-11-25 5:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 5:27 [PATCH 00/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 5:27 ` [PATCH 05/15] Make a bunch of functions static Simon Marchi
2019-11-25 5:27 ` [PATCH 11/15] Remove declaration of tui_set_var_cmd, make definition static Simon Marchi
2019-11-25 5:27 ` [PATCH 15/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 22:06 ` Tom Tromey
2019-11-25 22:11 ` Simon Marchi
2019-11-26 14:12 ` Tom Tromey
2019-11-26 19:48 ` Simon Marchi
2019-11-25 5:27 ` Simon Marchi [this message]
2019-11-25 5:27 ` [PATCH 12/15] Make functions static in unittests Simon Marchi
2019-11-25 5:27 ` [PATCH 01/15] Add back declarations for _initialize functions Simon Marchi
2020-01-09 18:46 ` John Baldwin
2020-01-09 22:23 ` Simon Marchi
2020-01-09 22:33 ` Tom Tromey
2020-01-09 22:50 ` Simon Marchi
2020-01-10 18:43 ` Tom Tromey
2020-01-10 21:46 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 06/15] Remove dict_empty/mdict_empty Simon Marchi
2019-11-25 5:27 ` [PATCH 04/15] Remove unused function set_gdb_completion_word_break_characters Simon Marchi
2019-11-25 5:27 ` [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Simon Marchi
2019-11-25 5:27 ` [PATCH 13/15] Remove simulator_command declaration, make static Simon Marchi
2019-11-25 5:27 ` [PATCH 07/15] Remove unused overload of exit_inferior_silent Simon Marchi
2019-11-25 5:33 ` [PATCH 10/15] Remove unused rbreak_command_wrapper and other declarations Simon Marchi
2019-11-25 5:33 ` [PATCH 09/15] Add declaration to python init func Simon Marchi
2019-11-25 5:33 ` [PATCH 14/15] Fix declaration of sparc_xfer_wcookie Simon Marchi
2019-11-25 5:33 ` [PATCH 08/15] Remove info_terminal_command declaration, make definition static Simon Marchi
2019-11-25 22:08 ` [PATCH 00/15] Enable -Wmissing-declarations diagnostic Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125052655.22696-4-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox