From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 15/15] Enable -Wmissing-declarations diagnostic
Date: Mon, 25 Nov 2019 22:11:00 -0000 [thread overview]
Message-ID: <0f51f45b-f622-d6e1-9da5-bff70aba1cda@efficios.com> (raw)
In-Reply-To: <8736eb8vc2.fsf@tromey.com>
On 2019-11-25 5:06 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> Now that most warnings of this kind are fixed, we can enable
> Simon> -Wmissing-declarations. I say "most", because it is likely that there
> Simon> are some more in some configurations I am not able to build, but they
> Simon> should be pretty easy to fix.
>
> Simon> gdb/ChangeLog:
>
> Simon> * warning.m4: Add -Wmissing-declarations to build_warnings.
> Simon> * configure: Re-generate.
>
> gdbserver uses warning.m4, so you have to also rebuild configure there
> and fix up any issues -- otherwise, the next person to rebuild
> gdbserver/configure will be surprised.
Doh. I was really susprised that gdbserver had zero occurence of this warning!
Do patches 2 to 8 and 10 to 14 look ok to you? If so, I would probably push them
right away since I believe they are good cleanups in any case.
Patches 1 and 9 are not really important until we are ready to switch the warning
on.
Simon
next prev parent reply other threads:[~2019-11-25 22:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 5:27 [PATCH 00/15] " Simon Marchi
2019-11-25 5:27 ` [PATCH 04/15] Remove unused function set_gdb_completion_word_break_characters Simon Marchi
2019-11-25 5:27 ` [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Simon Marchi
2019-11-25 5:27 ` [PATCH 06/15] Remove dict_empty/mdict_empty Simon Marchi
2019-11-25 5:27 ` [PATCH 01/15] Add back declarations for _initialize functions Simon Marchi
2020-01-09 18:46 ` John Baldwin
2020-01-09 22:23 ` Simon Marchi
2020-01-09 22:33 ` Tom Tromey
2020-01-09 22:50 ` Simon Marchi
2020-01-10 18:43 ` Tom Tromey
2020-01-10 21:46 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 12/15] Make functions static in unittests Simon Marchi
2019-11-25 5:27 ` [PATCH 15/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 22:06 ` Tom Tromey
2019-11-25 22:11 ` Simon Marchi [this message]
2019-11-26 14:12 ` Tom Tromey
2019-11-26 19:48 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 03/15] Add missing includes in dwarf-index-write.c and mi/mi-interp.c Simon Marchi
2019-11-25 5:27 ` [PATCH 11/15] Remove declaration of tui_set_var_cmd, make definition static Simon Marchi
2019-11-25 5:27 ` [PATCH 05/15] Make a bunch of functions static Simon Marchi
2019-11-25 5:27 ` [PATCH 07/15] Remove unused overload of exit_inferior_silent Simon Marchi
2019-11-25 5:27 ` [PATCH 13/15] Remove simulator_command declaration, make static Simon Marchi
2019-11-25 5:33 ` [PATCH 10/15] Remove unused rbreak_command_wrapper and other declarations Simon Marchi
2019-11-25 5:33 ` [PATCH 09/15] Add declaration to python init func Simon Marchi
2019-11-25 5:33 ` [PATCH 08/15] Remove info_terminal_command declaration, make definition static Simon Marchi
2019-11-25 5:33 ` [PATCH 14/15] Fix declaration of sparc_xfer_wcookie Simon Marchi
2019-11-25 22:08 ` [PATCH 00/15] Enable -Wmissing-declarations diagnostic Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f51f45b-f622-d6e1-9da5-bff70aba1cda@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox