From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74512 invoked by alias); 25 Nov 2019 22:11:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74451 invoked by uid 89); 25 Nov 2019 22:11:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=warning!, cleanups, person X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 22:11:07 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id D0B64423868; Mon, 25 Nov 2019 17:11:05 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id Vcs6R89MK105; Mon, 25 Nov 2019 17:11:05 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 8990D423864; Mon, 25 Nov 2019 17:11:05 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 8990D423864 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1574719865; bh=s/L5BII8Yb+TUUdbt9XOCs0In0vtWn10i/rMFo4YFwI=; h=To:From:Message-ID:Date:MIME-Version; b=oI+kFYjoIuZ/Yin9837Krjs25xKbgAH8+YJQeShjpY5Tk5/WZ73AinVsUUV/BQLaW lRpgkDwRpOg0B8LepziHXcA1VF+1qoR4882h7MOC9nQO0QsU7GLD5Raf874a6uxn/Y kI5D8ty3xSX8DKxc7cOrMNarn13ETqm58w/lOyqVUpROqztGQInGHaDhWkRi90KCx6 bufGI++BMCIwf8f8WsqDIxgFI2chmyE480TEnlmAz6KGIXojsz5OljiwV510JAzKcU YNJHraAl55C1280VSPgu0EyN8E6WIHudRNu0tIEAoeLPD4kzewzZq7MHUqFUKr0ZqA to+yIz19WE0tg== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id us5r32Q3wcfh; Mon, 25 Nov 2019 17:11:05 -0500 (EST) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 68821423851; Mon, 25 Nov 2019 17:11:05 -0500 (EST) Subject: Re: [PATCH 15/15] Enable -Wmissing-declarations diagnostic To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20191125052655.22696-1-simon.marchi@efficios.com> <20191125052655.22696-16-simon.marchi@efficios.com> <8736eb8vc2.fsf@tromey.com> From: Simon Marchi Message-ID: <0f51f45b-f622-d6e1-9da5-bff70aba1cda@efficios.com> Date: Mon, 25 Nov 2019 22:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8736eb8vc2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-11/txt/msg00850.txt.bz2 On 2019-11-25 5:06 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Now that most warnings of this kind are fixed, we can enable > Simon> -Wmissing-declarations. I say "most", because it is likely that there > Simon> are some more in some configurations I am not able to build, but they > Simon> should be pretty easy to fix. > > Simon> gdb/ChangeLog: > > Simon> * warning.m4: Add -Wmissing-declarations to build_warnings. > Simon> * configure: Re-generate. > > gdbserver uses warning.m4, so you have to also rebuild configure there > and fix up any issues -- otherwise, the next person to rebuild > gdbserver/configure will be surprised. Doh. I was really susprised that gdbserver had zero occurence of this warning! Do patches 2 to 8 and 10 to 14 look ok to you? If so, I would probably push them right away since I believe they are good cleanups in any case. Patches 1 and 9 are not really important until we are ready to switch the warning on. Simon